[clang] [clang][Dependency Scanning] Report Exported Modules during Scanning (PR #137421)

Cyndy Ishida via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 29 09:06:53 PDT 2025


================
@@ -115,6 +115,15 @@ struct ModuleID {
   }
 };
 
+struct ExtendedModuleID {
----------------
cyndyishida wrote:

nit: why not use a `std::pair`? It comes with operator overloads.
Also, assuming this field is only intended for representing objects in `ClangModuleDeps`, maybe the type should be named `ClangModuleDepInfo`?

Otherwise, it's not clear to me why & when a `ModuleID` needs to be extended. 

https://github.com/llvm/llvm-project/pull/137421


More information about the cfe-commits mailing list