[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

[Marco Elver via cfe-commits]

================
@@ -81,26 +81,25 @@ static bool isCalleeArrow(const Expr *E) {
   return ME ? ME->isArrow() : false;
 }
 
-static StringRef ClassifyDiagnostic(const CapabilityAttr *A) {
-  return A->getName();
-}
-
-static StringRef ClassifyDiagnostic(QualType VDT) {
+static CapabilityExpr makeCapabilityExpr(const til::SExpr *E, QualType VDT,
----------------
melver wrote:

I'm simplifying this. The only place where it's not yet know if it's a capability is the ScopedLockableAttr case. If we solve that, then we can have makeCapabilityExpr() - or rather, just a constructor that takes QualType.

https://github.com/llvm/llvm-project/pull/137133