[clang] [llvm] [PowerPC] frontend get target feature from backend with cpu name (PR #137670)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 28 10:14:16 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions c,h,cpp -- clang/lib/Basic/Targets/PPC.cpp clang/test/CodeGenCXX/cxx11-thread-local-reference.cpp clang/test/Driver/aix-shared-lib-tls-model-opt.c clang/test/Driver/aix-small-local-exec-dynamic-tls.c clang/test/Driver/ppc-crbits.cpp clang/test/Driver/ppc-isa-features.cpp llvm/include/llvm/MC/MCSubtargetInfo.h llvm/include/llvm/TargetParser/PPCTargetParser.h llvm/lib/MC/MCSubtargetInfo.cpp llvm/lib/TargetParser/PPCTargetParser.cpp llvm/utils/TableGen/SubtargetEmitter.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/Basic/Targets/PPC.cpp b/clang/lib/Basic/Targets/PPC.cpp
index 2a1024be1..b6ff8e11c 100644
--- a/clang/lib/Basic/Targets/PPC.cpp
+++ b/clang/lib/Basic/Targets/PPC.cpp
@@ -524,8 +524,8 @@ bool PPCTargetInfo::initFeatureMap(
llvm::PPC::getPPCDefaultTargetFeatures(TheTriple,
llvm::PPC::normalizeCPUName(CPU));
if (FeaturesOpt.has_value())
- Features = FeaturesOpt.value();
-
+ Features = FeaturesOpt.value();
+
if (!ppcUserFeaturesCheck(Diags, FeaturesVec))
return false;
diff --git a/llvm/include/llvm/MC/MCSubtargetInfo.h b/llvm/include/llvm/MC/MCSubtargetInfo.h
index 287aaf591..87028271e 100644
--- a/llvm/include/llvm/MC/MCSubtargetInfo.h
+++ b/llvm/include/llvm/MC/MCSubtargetInfo.h
@@ -48,12 +48,12 @@ struct BasicSubtargetFeatureKV {
return StringRef(Key) < StringRef(Other.Key);
}
BasicSubtargetFeatureKV(const char *Key, unsigned Value,
- FeatureBitArray Implies)
+ FeatureBitArray Implies)
: Key(Key), Value(Value), Implies(Implies) {}
};
struct SubtargetFeatureKV : BasicSubtargetFeatureKV {
- const char *Desc; ///< Help descriptor
+ const char *Desc; ///< Help descriptor
SubtargetFeatureKV(const char *Key, const char *Desc, unsigned Value,
FeatureBitArray Implies)
: BasicSubtargetFeatureKV(Key, Value, Implies), Desc(Desc) {}
@@ -78,7 +78,7 @@ struct BasicSubtargetSubTypeKV {
};
struct SubtargetSubTypeKV : BasicSubtargetSubTypeKV {
- FeatureBitArray TuneImplies; ///< K-V bit mask
+ FeatureBitArray TuneImplies; ///< K-V bit mask
const MCSchedModel *SchedModel;
};
diff --git a/llvm/utils/TableGen/SubtargetEmitter.cpp b/llvm/utils/TableGen/SubtargetEmitter.cpp
index be1409f65..4498a75d9 100644
--- a/llvm/utils/TableGen/SubtargetEmitter.cpp
+++ b/llvm/utils/TableGen/SubtargetEmitter.cpp
@@ -274,8 +274,9 @@ unsigned SubtargetEmitter::featureKeyValues(raw_ostream &OS,
// Begin feature table.
OS << "// Sorted (by key) array of values for CPU features.\n"
- << "extern const llvm::" << (IsEmitBasic ? "Basic" : "") << "SubtargetFeatureKV "
- << (IsEmitBasic ? "Basic" : "") << Target << "FeatureKV[] = {\n";
+ << "extern const llvm::" << (IsEmitBasic ? "Basic" : "")
+ << "SubtargetFeatureKV " << (IsEmitBasic ? "Basic" : "") << Target
+ << "FeatureKV[] = {\n";
for (const Record *Feature : FeatureList) {
// Next feature
@@ -357,8 +358,9 @@ unsigned SubtargetEmitter::cpuKeyValues(raw_ostream &OS,
// Begin processor table.
OS << "// Sorted (by key) array of values for CPU subtype.\n"
- << "extern const llvm::" << (IsEmitBasic ? "Basic" : "") << "SubtargetSubTypeKV "
- << (IsEmitBasic ? "Basic" : "") << Target << "SubTypeKV[] = {\n";
+ << "extern const llvm::" << (IsEmitBasic ? "Basic" : "")
+ << "SubtargetSubTypeKV " << (IsEmitBasic ? "Basic" : "") << Target
+ << "SubTypeKV[] = {\n";
for (const Record *Processor : ProcessorList) {
StringRef Name = Processor->getValueAsString("Name");
``````````
</details>
https://github.com/llvm/llvm-project/pull/137670
More information about the cfe-commits
mailing list