[clang] [clang] Use range constructors of *Set (NFC) (PR #137574)
Kazu Hirata via cfe-commits
cfe-commits at lists.llvm.org
Sun Apr 27 20:17:52 PDT 2025
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/137574
None
>From b26fb883437b6822cfab50189d1fe96cb3ca330f Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sun, 13 Apr 2025 17:34:57 -0700
Subject: [PATCH] [clang] Use range constructors of *Set (NFC)
---
.../lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp | 2 +-
clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp | 7 +++----
clang/lib/Sema/SemaTemplateVariadic.cpp | 2 +-
clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp | 2 +-
.../Analysis/FlowSensitive/SimplifyConstraintsTest.cpp | 3 +--
5 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp b/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
index 1c4fe5c6d5019..6409b4bc8ff4d 100644
--- a/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
+++ b/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
@@ -86,7 +86,7 @@ StorageLocation &DataflowAnalysisContext::createStorageLocation(QualType Type) {
// Can't use `StringSet` as the return type as it doesn't support `operator==`.
template <typename T>
static llvm::DenseSet<llvm::StringRef> getKeys(const llvm::StringMap<T> &Map) {
- return llvm::DenseSet<llvm::StringRef>(Map.keys().begin(), Map.keys().end());
+ return llvm::DenseSet<llvm::StringRef>(llvm::from_range, Map.keys());
}
RecordStorageLocation &DataflowAnalysisContext::createRecordStorageLocation(
diff --git a/clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp b/clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp
index f697c13f4c522..59a5f7b914ce5 100644
--- a/clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp
+++ b/clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp
@@ -129,8 +129,8 @@ static RecordDecl *buildRecordForGlobalizedVars(
// };
RecordDecl *GlobalizedRD = C.buildImplicitRecord("_globalized_locals_ty");
GlobalizedRD->startDefinition();
- llvm::SmallPtrSet<const ValueDecl *, 16> SingleEscaped(
- EscapedDeclsForTeams.begin(), EscapedDeclsForTeams.end());
+ llvm::SmallPtrSet<const ValueDecl *, 16> SingleEscaped(llvm::from_range,
+ EscapedDeclsForTeams);
for (const auto &Pair : GlobalizedVars) {
const ValueDecl *VD = Pair.second;
QualType Type = VD->getType();
@@ -322,8 +322,7 @@ class CheckVarsEscapingDeclContext final
public:
CheckVarsEscapingDeclContext(CodeGenFunction &CGF,
ArrayRef<const ValueDecl *> TeamsReductions)
- : CGF(CGF), EscapedDecls(TeamsReductions.begin(), TeamsReductions.end()) {
- }
+ : CGF(CGF), EscapedDecls(llvm::from_range, TeamsReductions) {}
virtual ~CheckVarsEscapingDeclContext() = default;
void VisitDeclStmt(const DeclStmt *S) {
if (!S)
diff --git a/clang/lib/Sema/SemaTemplateVariadic.cpp b/clang/lib/Sema/SemaTemplateVariadic.cpp
index 87682233c5246..34fec069d6df6 100644
--- a/clang/lib/Sema/SemaTemplateVariadic.cpp
+++ b/clang/lib/Sema/SemaTemplateVariadic.cpp
@@ -498,7 +498,7 @@ bool Sema::DiagnoseUnexpandedParameterPackInRequiresExpr(RequiresExpr *RE) {
// We only care about unexpanded references to the RequiresExpr's own
// parameter packs.
auto Parms = RE->getLocalParameters();
- llvm::SmallPtrSet<NamedDecl*, 8> ParmSet(Parms.begin(), Parms.end());
+ llvm::SmallPtrSet<NamedDecl *, 8> ParmSet(llvm::from_range, Parms);
SmallVector<UnexpandedParameterPack, 2> UnexpandedParms;
for (auto Parm : Unexpanded)
if (ParmSet.contains(Parm.first.dyn_cast<NamedDecl *>()))
diff --git a/clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp b/clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp
index 90c95d5cf60d8..b88e6db7cceb7 100644
--- a/clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp
+++ b/clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp
@@ -77,7 +77,7 @@ static int countSymbols(Lang Language) {
}
}
#undef SYMBOL
- return llvm::DenseSet<StringRef>(Symbols.begin(), Symbols.end()).size();
+ return llvm::DenseSet<StringRef>(llvm::from_range, Symbols).size();
}
static int initialize(Lang Language) {
diff --git a/clang/unittests/Analysis/FlowSensitive/SimplifyConstraintsTest.cpp b/clang/unittests/Analysis/FlowSensitive/SimplifyConstraintsTest.cpp
index 1f34ae076d5ed..c82199c15e068 100644
--- a/clang/unittests/Analysis/FlowSensitive/SimplifyConstraintsTest.cpp
+++ b/clang/unittests/Analysis/FlowSensitive/SimplifyConstraintsTest.cpp
@@ -24,8 +24,7 @@ class SimplifyConstraintsTest : public ::testing::Test {
protected:
llvm::SetVector<const Formula *> parse(StringRef Lines) {
std::vector<const Formula *> formulas = test::parseFormulas(A, Lines);
- llvm::SetVector<const Formula *> Constraints(formulas.begin(),
- formulas.end());
+ llvm::SetVector<const Formula *> Constraints(llvm::from_range, formulas);
return Constraints;
}
More information about the cfe-commits
mailing list