[clang] [Serialization] Fix lazy template loading (PR #133057)

Chuanqi Xu via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 27 19:31:41 PDT 2025


================
@@ -21,17 +21,6 @@ using namespace clang;
 namespace {
 
 class TemplateArgumentHasher {
-  // If we bail out during the process of calculating hash values for
-  // template arguments for any reason. We're allowed to do it since
-  // TemplateArgumentHasher are only required to give the same hash value
-  // for the same template arguments, but not required to give different
-  // hash value for different template arguments.
-  //
-  // So in the worst case, it is still a valid implementation to give all
-  // inputs the same BailedOutValue as output.
-  bool BailedOut = false;
-  static constexpr unsigned BailedOutValue = 0x12345678;
----------------
ChuanqiXu9 wrote:

Not yet. We can split this in two commits, then if anything bad happens, we can revert precisely.

https://github.com/llvm/llvm-project/pull/133057


More information about the cfe-commits mailing list