[clang] [Clang][NFC] Const correctness fix for range based for loop (PR #137431)

Shafik Yaghmour via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 25 19:08:36 PDT 2025


https://github.com/shafik created https://github.com/llvm/llvm-project/pull/137431

Static analysis flagged that we did not make const a item declaration b/c we did not modify it all during the loop.

>From 6b1e4f4c170c3f15697209f385397f295d15d2db Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour <shafik.yaghmour at intel.com>
Date: Fri, 25 Apr 2025 19:05:04 -0700
Subject: [PATCH] [Clang][NFC] Const correctness fix for range based for loop

Static analysis flagged that we did not make const a item declaration b/c we did
not modify it all during the loop.
---
 clang/utils/TableGen/ClangBuiltinTemplatesEmitter.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/utils/TableGen/ClangBuiltinTemplatesEmitter.cpp b/clang/utils/TableGen/ClangBuiltinTemplatesEmitter.cpp
index 34bc782e007d5..de79743a06e1f 100644
--- a/clang/utils/TableGen/ClangBuiltinTemplatesEmitter.cpp
+++ b/clang/utils/TableGen/ClangBuiltinTemplatesEmitter.cpp
@@ -107,7 +107,7 @@ ParseTemplateParameterList(ParserState &PS,
   }
 
   bool First = true;
-  for (auto e : Params) {
+  for (const auto &e : Params) {
     if (First) {
       First = false;
       Code << e;



More information about the cfe-commits mailing list