https://github.com/andykaylor approved this pull request. I've still got a couple of open nits about the comments in CIRDialect.cpp, but otherwise this looks good. https://github.com/llvm/llvm-project/pull/137184