[clang] [clang] Merge gtest binaries into AllClangUnitTests (PR #134196)

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 25 13:04:38 PDT 2025


================
@@ -304,7 +304,7 @@ getCodeModel(const CodeGenOptions &CodeGenOpts) {
                            .Case("kernel", llvm::CodeModel::Kernel)
                            .Case("medium", llvm::CodeModel::Medium)
                            .Case("large", llvm::CodeModel::Large)
-                           .Case("default", ~1u)
+                           .Cases("default", "", ~1u)
----------------
rnk wrote:

Basically, after my change, some Frontend tests now exercise this codepath without setting up a code model, and they hit the assert below. What changed is that now the target they are generating IR for is registered, so this codepath executes, when it didn't before my change. Interpreting "empty" as the default code model here seemed like the most sensible thing to do, rather than adding logic to those tests to explicitly set a code model.

https://github.com/llvm/llvm-project/pull/134196


More information about the cfe-commits mailing list