[clang-tools-extra] [include-cleaner] rename enabled flags to `disable-*` (PR #132991)

via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 25 12:58:12 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang-tools-extra/include-cleaner/test/tool.cpp clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp b/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp
index dd853950d..ba7c9f676 100644
--- a/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp
+++ b/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp
@@ -92,7 +92,8 @@ cl::opt<bool> Edit{
 };
 cl::opt<bool> Insert{
     "insert",
-    cl::desc("Allow header insertions (deprecated. Use -disable-insert instead)"),
+    cl::desc(
+        "Allow header insertions (deprecated. Use -disable-insert instead)"),
     cl::init(true),
     cl::cat(IncludeCleaner),
 };
@@ -196,17 +197,19 @@ private:
                 getCompilerInstance().getPreprocessor(), HeaderFilter);
 
     if (!Insert) {
-      llvm::errs() << "`-insert=0` is deprecated in favor of `-disable-insert`. "
-                      "The old flag was confusing since it suggested that inserts "
-                      "were disabled by default, when they were actually enabled. "
-                      "See https://github.com/llvm/llvm-project/issues/132983\n";
+      llvm::errs()
+          << "`-insert=0` is deprecated in favor of `-disable-insert`. "
+             "The old flag was confusing since it suggested that inserts "
+             "were disabled by default, when they were actually enabled. "
+             "See https://github.com/llvm/llvm-project/issues/132983\n";
     }
 
     if (!Remove) {
-      llvm::errs() << "`-remove=0` is deprecated in favor of `-disable-remove`. "
-                      "The old flag was confusing since it suggested that removes "
-                      "were disabled by default, when they were actually enabled. "
-                      "See https://github.com/llvm/llvm-project/issues/132983\n";
+      llvm::errs()
+          << "`-remove=0` is deprecated in favor of `-disable-remove`. "
+             "The old flag was confusing since it suggested that removes "
+             "were disabled by default, when they were actually enabled. "
+             "See https://github.com/llvm/llvm-project/issues/132983\n";
     }
 
     if (!Insert || DisableInsert)

``````````

</details>


https://github.com/llvm/llvm-project/pull/132991


More information about the cfe-commits mailing list