[clang] [clang] Fix a use-after-free in expression evaluation (PR #118480)

[kadir çetinkaya via cfe-commits]

kadircet wrote:

Put together a new fix based on the discussions here in https://github.com/llvm/llvm-project/pull/137163, PTAL.

@AaronBallman I am afraid this might no longer fix the crashes you're seeing internally though, as the new fix is focused on handling of `CompoundLiteralExpr`s, whereas the failures you mentioned seem to involve different C++ constructs.

https://github.com/llvm/llvm-project/pull/118480