[clang] [clang][modules] Minor improvements to diagnosing `out of date` errors (PR #136612)

[Jan Svoboda via cfe-commits]

================
@@ -3349,10 +3351,29 @@ ASTReader::ReadControlBlock(ModuleFile &F,
                                       .getModuleCache()
                                       .getInMemoryModuleCache()
                                       .isPCMFinal(F.FileName);
-      if (isDiagnosedResult(Result, Capabilities) || recompilingFinalized)
+      if (isDiagnosedResult(Result, Capabilities) || recompilingFinalized) {
----------------
jansvoboda11 wrote:

Is it? `isDiagnosedResult(Result, Capabilities)` returns `true` for other cases, not only `OutOfDate` errors.

https://github.com/llvm/llvm-project/pull/136612