[clang] [clang] Constant-evaluate format strings as last resort (PR #135864)

[via cfe-commits]

================
@@ -10170,6 +10170,8 @@ def warn_format_bool_as_character : Warning<
   "using '%0' format specifier, but argument has boolean value">,
   InGroup<Format>;
 def note_format_string_defined : Note<"format string is defined here">;
+def note_format_string_evaluated_to : Note<
+  "format string was constant-evaluated">;
----------------
apple-fcloutier wrote:

I noodled on it and I think it's a little awkward, but I understand why we're trying to stay away from wording with a standardized definition. How do you feel about "format string resolved to a constant string"?

https://github.com/llvm/llvm-project/pull/135864