[clang] [analyzer] Workaround for unintended slowdown (scope increase) (PR #136720)

[Donát Nagy via cfe-commits]

================
@@ -81,10 +81,6 @@ class FunctionSummariesTy {
     I->second.MayInline = 0;
   }
 
-  void markReachedMaxBlockCount(const Decl *D) {
-    markShouldNotInline(D);
-  }
----------------
NagyDonat wrote:

I'm removing this function (by inlining its trivial definition) because I feel that its nondescript sneaky name significantly contributed to the fact that I did not know about this heuristic previously.

**Please name functions clearly** – refer to their effects instead of just naming their call site (which is not helpful when I'm already reading the code that calls them)!

https://github.com/llvm/llvm-project/pull/136720