[clang-tools-extra] [clang-doc] Avoid C-style casts (PR #136390)

Paul Kirth via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 18 17:29:52 PDT 2025


https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/136390

None

>From 9352efa3168ac7097f3bb4aa2d2722ab979c01e0 Mon Sep 17 00:00:00 2001
From: Paul Kirth <paulkirth at google.com>
Date: Fri, 18 Apr 2025 17:02:42 -0700
Subject: [PATCH] [clang-doc] Avoid C-style casts

---
 clang-tools-extra/clang-doc/BitcodeReader.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/clang-tools-extra/clang-doc/BitcodeReader.cpp b/clang-tools-extra/clang-doc/BitcodeReader.cpp
index 1f2fb0a8b2b85..03715192a0016 100644
--- a/clang-tools-extra/clang-doc/BitcodeReader.cpp
+++ b/clang-tools-extra/clang-doc/BitcodeReader.cpp
@@ -46,7 +46,7 @@ llvm::Error decodeRecord(const Record &R, int &Field, llvm::StringRef Blob) {
   if (R[0] > INT_MAX)
     return llvm::createStringError(llvm::inconvertibleErrorCode(),
                                    "integer too large to parse");
-  Field = (int)R[0];
+  Field = static_cast<int>(R[0]);
   return llvm::Error::success();
 }
 
@@ -85,7 +85,7 @@ llvm::Error decodeRecord(const Record &R, std::optional<Location> &Field,
   if (R[0] > INT_MAX)
     return llvm::createStringError(llvm::inconvertibleErrorCode(),
                                    "integer too large to parse");
-  Field.emplace((int)R[0], Blob, (bool)R[1]);
+  Field.emplace(static_cast<int>(R[0]), Blob, static_cast<bool>(R[1]));
   return llvm::Error::success();
 }
 
@@ -135,7 +135,7 @@ llvm::Error decodeRecord(const Record &R,
   if (R[0] > INT_MAX)
     return llvm::createStringError(llvm::inconvertibleErrorCode(),
                                    "integer too large to parse");
-  Field.emplace_back((int)R[0], Blob, (bool)R[1]);
+  Field.emplace_back(static_cast<int>(R[0]), Blob, static_cast<bool>(R[1]));
   return llvm::Error::success();
 }
 



More information about the cfe-commits mailing list