[clang] [CIR][NFC] Simplify BoolAttr builders (PR #136366)

Andy Kaylor via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 18 15:48:17 PDT 2025


================
@@ -692,9 +692,7 @@ mlir::LogicalResult CIRToLLVMConstantOpLowering::matchAndRewrite(
     // during a pass as long as they don't live past the end of the pass.
     attr = op.getValue();
   } else if (mlir::isa<cir::BoolType>(op.getType())) {
-    int value = (op.getValue() ==
-                 cir::BoolAttr::get(getContext(),
-                                    cir::BoolType::get(getContext()), true));
+    int value = (op.getValue() == cir::BoolAttr::get(getContext(), true));
----------------
andykaylor wrote:

Is there a reason we can't just use `int value = mlir::cast<cir::BoolAttr>(op.getValue()).getValue()` here?

https://github.com/llvm/llvm-project/pull/136366


More information about the cfe-commits mailing list