[clang] c5d5972 - [clang][bytecode] Reject constexpr-unknown values in CheckStore (#136279)

[via cfe-commits]

Author: Timm Baeder
Date: 2025-04-18T12:48:16+02:00
New Revision: c5d59723cbf9743f7a0534a6ca87383abb6785a7

URL: https://github.com/llvm/llvm-project/commit/c5d59723cbf9743f7a0534a6ca87383abb6785a7
DIFF: https://github.com/llvm/llvm-project/commit/c5d59723cbf9743f7a0534a6ca87383abb6785a7.diff

LOG: [clang][bytecode] Reject constexpr-unknown values in CheckStore (#136279)

Added: 
    

Modified: 
    clang/lib/AST/ByteCode/Interp.cpp
    clang/test/CodeGen/p0963r3.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/AST/ByteCode/Interp.cpp b/clang/lib/AST/ByteCode/Interp.cpp
index 4625154ac353d..b755a072fec88 100644
--- a/clang/lib/AST/ByteCode/Interp.cpp
+++ b/clang/lib/AST/ByteCode/Interp.cpp
@@ -790,6 +790,8 @@ bool CheckStore(InterpState &S, CodePtr OpPC, const Pointer &Ptr) {
     return false;
   if (!CheckConst(S, OpPC, Ptr))
     return false;
+  if (!S.inConstantContext() && isConstexprUnknown(Ptr))
+    return false;
   return true;
 }
 

diff  --git a/clang/test/CodeGen/p0963r3.cpp b/clang/test/CodeGen/p0963r3.cpp
index 4a5e6c3f5d751..65d33397e6173 100644
--- a/clang/test/CodeGen/p0963r3.cpp
+++ b/clang/test/CodeGen/p0963r3.cpp
@@ -1,5 +1,5 @@
-// RUN: %clang_cc1 -std=c++2c -verify -emit-llvm -triple=x86_64-pc-linux-gnu %s -o - | FileCheck %s
-// RUN: %clang_cc1 -std=c++2c -verify -fsyntax-only -fexperimental-new-constant-interpreter -triple=x86_64-pc-linux-gnu %s
+// RUN: %clang_cc1 -std=c++2c -verify -emit-llvm -triple=x86_64-pc-linux-gnu %s -o -                                         | FileCheck %s
+// RUN: %clang_cc1 -std=c++2c -verify -emit-llvm -triple=x86_64-pc-linux-gnu %s -o - -fexperimental-new-constant-interpreter | FileCheck %s
 // expected-no-diagnostics
 
 namespace std {