[clang] [llvm] [HLSL][RootSignature] Implement initial parsing of the descriptor table clause params (PR #133800)

Thu Apr 17 20:54:41 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while building `clang,llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/6814

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[5108/7780] Creating library symlink lib/libMLIRArithAttrToLLVMConversion.so
[5109/7780] Creating library symlink lib/libMLIRQuantTransforms.so
[5110/7780] Linking CXX shared library lib/libMLIRComplexToStandard.so.21.0git
[5111/7780] Creating library symlink lib/libMLIRSparseTensorUtils.so
[5112/7780] Creating library symlink lib/libMLIRComplexToStandard.so
[5113/7780] Creating library symlink lib/libMLIRTosaDialect.so
[5114/7780] Linking CXX shared library lib/libMLIRLLVMCommonConversion.so.21.0git
[5115/7780] Creating library symlink lib/libMLIRVectorDialect.so
[5116/7780] Creating library symlink lib/libMLIRLLVMCommonConversion.so
[5117/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o
FAILED: tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o 
ccache /usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/tools/clang/lib/Parse -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/clang/lib/Parse -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/clang/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/tools/clang/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o -MF tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o.d -o tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o -c /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/clang/lib/Parse/ParseHLSLRootSignature.cpp
In file included from /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/clang/include/clang/Parse/ParseHLSLRootSignature.h:23,
                 from /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/clang/lib/Parse/ParseHLSLRootSignature.cpp:9:
/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h:42:12: error: declaration of ‘llvm::hlsl::rootsig::Register llvm::hlsl::rootsig::DescriptorTableClause::Register’ changes meaning of ‘Register’ [-fpermissive]
   42 |   Register Register;
      |            ^~~~~~~~
/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h:28:8: note: ‘Register’ declared here as ‘struct llvm::hlsl::rootsig::Register’
   28 | struct Register {
      |        ^~~~~~~~
[5118/7780] Linking CXX shared library lib/libMLIRVCIXDialect.so.21.0git
[5119/7780] Linking CXX shared library lib/libMLIRTosaTransforms.so.21.0git
[5120/7780] Linking CXX shared library lib/libMLIROpenACCDialect.so.21.0git
[5121/7780] Linking CXX shared library lib/libMLIROpenMPDialect.so.21.0git
[5122/7780] Linking CXX shared library lib/libMLIRNVVMDialect.so.21.0git
[5123/7780] Linking CXX shared library lib/libMLIRTensorTilingInterfaceImpl.so.21.0git
[5124/7780] Linking CXX shared library lib/libMLIRArmNeon2dToIntr.so.21.0git
[5125/7780] Linking CXX shared library lib/libMLIRComplexToLLVM.so.21.0git
[5126/7780] Linking CXX shared library lib/libMLIRROCDLDialect.so.21.0git
[5127/7780] Linking CXX shared library lib/libLLVMCodeGen.so.21.0git
[5128/7780] Linking CXX shared library lib/libLLVMipo.so.21.0git
[5129/7780] Building AMDGPUGenAsmMatcher.inc...
[5130/7780] Building AMDGPUGenGlobalISel.inc...
[5131/7780] Building AMDGPUGenRegisterBank.inc...
[5132/7780] Building AMDGPUGenInstrInfo.inc...
[5133/7780] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[5134/7780] Building CXX object tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/DiagnosticIDs.cpp.o
[5135/7780] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[5136/7780] Building AMDGPUGenRegisterInfo.inc...
[5137/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseAST.cpp.o
[5138/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseInit.cpp.o
[5139/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSL.cpp.o
[5140/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseCXXInlineMethods.cpp.o
[5141/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseStmt.cpp.o
[5142/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseTemplate.cpp.o
[5143/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseObjc.cpp.o
[5144/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseExprCXX.cpp.o
[5145/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseStmtAsm.cpp.o
[5146/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseDeclCXX.cpp.o
Step 7 (build cmake config) failure: build cmake config (failure)
...
[5108/7780] Creating library symlink lib/libMLIRArithAttrToLLVMConversion.so
[5109/7780] Creating library symlink lib/libMLIRQuantTransforms.so
[5110/7780] Linking CXX shared library lib/libMLIRComplexToStandard.so.21.0git
[5111/7780] Creating library symlink lib/libMLIRSparseTensorUtils.so
[5112/7780] Creating library symlink lib/libMLIRComplexToStandard.so
[5113/7780] Creating library symlink lib/libMLIRTosaDialect.so
[5114/7780] Linking CXX shared library lib/libMLIRLLVMCommonConversion.so.21.0git
[5115/7780] Creating library symlink lib/libMLIRVectorDialect.so
[5116/7780] Creating library symlink lib/libMLIRLLVMCommonConversion.so
[5117/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o
FAILED: tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o 
ccache /usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/tools/clang/lib/Parse -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/clang/lib/Parse -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/clang/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/tools/clang/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o -MF tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o.d -o tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o -c /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/clang/lib/Parse/ParseHLSLRootSignature.cpp
In file included from /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/clang/include/clang/Parse/ParseHLSLRootSignature.h:23,
                 from /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/clang/lib/Parse/ParseHLSLRootSignature.cpp:9:
/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h:42:12: error: declaration of ‘llvm::hlsl::rootsig::Register llvm::hlsl::rootsig::DescriptorTableClause::Register’ changes meaning of ‘Register’ [-fpermissive]
   42 |   Register Register;
      |            ^~~~~~~~
/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h:28:8: note: ‘Register’ declared here as ‘struct llvm::hlsl::rootsig::Register’
   28 | struct Register {
      |        ^~~~~~~~
[5118/7780] Linking CXX shared library lib/libMLIRVCIXDialect.so.21.0git
[5119/7780] Linking CXX shared library lib/libMLIRTosaTransforms.so.21.0git
[5120/7780] Linking CXX shared library lib/libMLIROpenACCDialect.so.21.0git
[5121/7780] Linking CXX shared library lib/libMLIROpenMPDialect.so.21.0git
[5122/7780] Linking CXX shared library lib/libMLIRNVVMDialect.so.21.0git
[5123/7780] Linking CXX shared library lib/libMLIRTensorTilingInterfaceImpl.so.21.0git
[5124/7780] Linking CXX shared library lib/libMLIRArmNeon2dToIntr.so.21.0git
[5125/7780] Linking CXX shared library lib/libMLIRComplexToLLVM.so.21.0git
[5126/7780] Linking CXX shared library lib/libMLIRROCDLDialect.so.21.0git
[5127/7780] Linking CXX shared library lib/libLLVMCodeGen.so.21.0git
[5128/7780] Linking CXX shared library lib/libLLVMipo.so.21.0git
[5129/7780] Building AMDGPUGenAsmMatcher.inc...
[5130/7780] Building AMDGPUGenGlobalISel.inc...
[5131/7780] Building AMDGPUGenRegisterBank.inc...
[5132/7780] Building AMDGPUGenInstrInfo.inc...
[5133/7780] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[5134/7780] Building CXX object tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/DiagnosticIDs.cpp.o
[5135/7780] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[5136/7780] Building AMDGPUGenRegisterInfo.inc...
[5137/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseAST.cpp.o
[5138/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseInit.cpp.o
[5139/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSL.cpp.o
[5140/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseCXXInlineMethods.cpp.o
[5141/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseStmt.cpp.o
[5142/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseTemplate.cpp.o
[5143/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseObjc.cpp.o
[5144/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseExprCXX.cpp.o
[5145/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseStmtAsm.cpp.o
[5146/7780] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseDeclCXX.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/133800