[clang] [HLSL] Add a warning for implicit bindings (PR #135909)

[Joshua Batista via cfe-commits]

================
@@ -3278,6 +3284,9 @@ void SemaHLSL::processExplicitBindingsOnDecl(VarDecl *VD) {
           << static_cast<int>(RT);
     }
   }
+
+  if (!HasBinding && VD->getType()->isHLSLResourceRecord())
+    SemaRef.Diag(VD->getLocation(), diag::warn_hlsl_implicit_binding);
----------------
bob80905 wrote:

I would think ActOnFinishBuffer always executes when declaring a resource. Is there some case where the diagnostic is emitted here and ActOnFinishBuffer isn't called?

https://github.com/llvm/llvm-project/pull/135909