[clang] [clang-tools-extra] [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #135808)

Wed Apr 16 06:04:33 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `clang-tools-extra,clang` at step 8 "build-default".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/4082

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 8 (build-default) failure: cmake (failure)
...
462.558 [198/59/5171]Building CXX object tools\lldb\source\Plugins\LanguageRuntime\ObjC\AppleObjCRuntime\CMakeFiles\lldbPluginAppleObjCRuntime.dir\AppleObjCRuntime.cpp.obj
462.568 [198/58/5172]Building CXX object tools\lldb\source\Plugins\SystemRuntime\MacOSX\CMakeFiles\lldbPluginSystemRuntimeMacOSX.dir\AppleGetThreadItemInfoHandler.cpp.obj
462.654 [198/57/5173]Building CXX object tools\lldb\source\Plugins\Platform\NetBSD\CMakeFiles\lldbPluginPlatformNetBSD.dir\PlatformNetBSD.cpp.obj
462.756 [198/56/5174]Building CXX object tools\lldb\source\Plugins\LanguageRuntime\ObjC\GNUstepObjCRuntime\CMakeFiles\lldbPluginGNUstepObjCRuntime.dir\GNUstepObjCRuntime.cpp.obj
463.209 [198/55/5175]Building CXX object tools\lldb\source\Plugins\ExpressionParser\Clang\CMakeFiles\lldbPluginExpressionParserClang.dir\ASTResultSynthesizer.cpp.obj
463.237 [198/54/5176]Building CXX object tools\lldb\source\Plugins\LanguageRuntime\ObjC\CMakeFiles\lldbPluginObjCRuntime.dir\ObjCLanguageRuntime.cpp.obj
463.265 [198/53/5177]Building CXX object tools\lldb\source\Plugins\SystemRuntime\MacOSX\CMakeFiles\lldbPluginSystemRuntimeMacOSX.dir\AppleGetQueuesHandler.cpp.obj
463.318 [198/52/5178]Building CXX object tools\lldb\source\Plugins\Platform\Linux\CMakeFiles\lldbPluginPlatformLinux.dir\PlatformLinux.cpp.obj
463.726 [198/51/5179]Building CXX object tools\lldb\source\Plugins\ExpressionParser\Clang\CMakeFiles\lldbPluginExpressionParserClang.dir\ASTStructExtractor.cpp.obj
463.754 [198/50/5180]Building CXX object tools\lldb\source\Plugins\ExpressionParser\Clang\CMakeFiles\lldbPluginExpressionParserClang.dir\ClangModulesDeclVendor.cpp.obj
FAILED: tools/lldb/source/Plugins/ExpressionParser/Clang/CMakeFiles/lldbPluginExpressionParserClang.dir/ClangModulesDeclVendor.cpp.obj 
ccache C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1441~1.341\bin\Hostx64\x64\cl.exe  /nologo /TP -DCLANG_BUILD_STATIC -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-10\lldb-x-aarch64\build\tools\lldb\source\Plugins\ExpressionParser\Clang -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source\Plugins\ExpressionParser\Clang -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\build\tools\lldb\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\build\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\llvm\include -IC:\Python312\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\llvm\..\clang\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\build\tools\lldb\..\clang\include -IC:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source -IC:\buildbot\as-builder-10\lldb-x-aarch64\build\tools\lldb\source -D__OPTIMIZE__ /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -wd4251 -wd4275 -w14062 -we4238 /Gw /O2 /Ob2  -MD   -wd4018 -wd4068 -wd4150 -wd4201 -wd4251 -wd4521 -wd4530 -wd4589  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Fotools\lldb\source\Plugins\ExpressionParser\Clang\CMakeFiles\lldbPluginExpressionParserClang.dir\ClangModulesDeclVendor.cpp.obj /Fdtools\lldb\source\Plugins\ExpressionParser\Clang\CMakeFiles\lldbPluginExpressionParserClang.dir\lldbPluginExpressionParserClang.pdb /FS -c C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source\Plugins\ExpressionParser\Clang\ClangModulesDeclVendor.cpp
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source\Plugins\ExpressionParser\Clang\ClangModulesDeclVendor.cpp(360): error C2664: 'clang::ModuleLoadResult `anonymous-namespace'::ClangModulesDeclVendorImpl::DoGetModule(clang::ModuleIdPath,bool)': cannot convert argument 1 from 'T' to 'clang::ModuleIdPath'
        with
        [
            T=std::pair<clang::IdentifierInfo *,clang::SourceLocation>
        ]
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source\Plugins\ExpressionParser\Clang\ClangModulesDeclVendor.cpp(360): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source\Plugins\ExpressionParser\Clang\ClangModulesDeclVendor.cpp(112): note: see declaration of '`anonymous-namespace'::ClangModulesDeclVendorImpl::DoGetModule'
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source\Plugins\ExpressionParser\Clang\ClangModulesDeclVendor.cpp(360): note: while trying to match the argument list '(T, bool)'
        with
        [
            T=std::pair<clang::IdentifierInfo *,clang::SourceLocation>
        ]
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source\Plugins\ExpressionParser\Clang\ClangModulesDeclVendor.cpp(381): error C2664: 'clang::ModuleLoadResult `anonymous-namespace'::ClangModulesDeclVendorImpl::DoGetModule(clang::ModuleIdPath,bool)': cannot convert argument 1 from 'llvm::SmallVector<std::pair<clang::IdentifierInfo *,clang::SourceLocation>,4>' to 'clang::ModuleIdPath'
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source\Plugins\ExpressionParser\Clang\ClangModulesDeclVendor.cpp(381): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source\Plugins\ExpressionParser\Clang\ClangModulesDeclVendor.cpp(112): note: see declaration of '`anonymous-namespace'::ClangModulesDeclVendorImpl::DoGetModule'
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source\Plugins\ExpressionParser\Clang\ClangModulesDeclVendor.cpp(381): note: while trying to match the argument list '(llvm::SmallVector<std::pair<clang::IdentifierInfo *,clang::SourceLocation>,4>, bool)'
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\source\Plugins\ExpressionParser\Clang\ClangModulesDeclVendor.cpp(632): error C2039: 'second': is not a member of 'clang::IdentifierLoc'
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\llvm\..\clang\include\clang/Basic/IdentifierTable.h(1167): note: see declaration of 'clang::IdentifierLoc'
463.963 [198/49/5181]Building CXX object tools\lldb\source\Plugins\SystemRuntime\MacOSX\CMakeFiles\lldbPluginSystemRuntimeMacOSX.dir\SystemRuntimeMacOSX.cpp.obj
463.964 [198/48/5182]Linking CXX executable bin\clang-diff.exe
463.969 [198/47/5183]Building CXX object tools\lldb\source\Plugins\SystemRuntime\MacOSX\CMakeFiles\lldbPluginSystemRuntimeMacOSX.dir\AppleGetPendingItemsHandler.cpp.obj
463.970 [198/46/5184]Linking CXX executable bin\llvm-dwarfdump.exe
464.110 [198/45/5185]Building CXX object tools\lldb\source\Plugins\ExpressionParser\Clang\CMakeFiles\lldbPluginExpressionParserClang.dir\ClangASTSource.cpp.obj
464.188 [198/44/5186]Building CXX object tools\lldb\source\Plugins\SymbolFile\DWARF\CMakeFiles\lldbPluginSymbolFileDWARF.dir\DWARFASTParserClang.cpp.obj
464.220 [198/43/5187]Building CXX object tools\clang\tools\clang-repl\CMakeFiles\clang-repl.dir\ClangRepl.cpp.obj
464.515 [198/42/5188]Building CXX object tools\clang\tools\libclang\CMakeFiles\libclang.dir\CIndex.cpp.obj
464.626 [198/41/5189]Building CXX object tools\lldb\source\Plugins\SystemRuntime\MacOSX\CMakeFiles\lldbPluginSystemRuntimeMacOSX.dir\AbortWithPayloadFrameRecognizer.cpp.obj
464.785 [198/40/5190]Linking CXX executable bin\clang-refactor.exe
464.816 [198/39/5191]Building CXX object tools\lldb\source\Plugins\RegisterTypeBuilder\CMakeFiles\lldbPluginRegisterTypeBuilderClang.dir\RegisterTypeBuilderClang.cpp.obj
464.859 [198/38/5192]Building CXX object tools\lldb\source\Plugins\ExpressionParser\Clang\CMakeFiles\lldbPluginExpressionParserClang.dir\ClangUtilityFunction.cpp.obj
465.036 [198/37/5193]Building CXX object tools\lldb\source\Plugins\Language\ObjC\CMakeFiles\lldbPluginObjCLanguage.dir\NSException.cpp.obj
465.086 [198/36/5194]Building CXX object tools\lldb\source\Plugins\LanguageRuntime\CPlusPlus\ItaniumABI\CMakeFiles\lldbPluginCXXItaniumABI.dir\ItaniumABILanguageRuntime.cpp.obj
465.111 [198/35/5195]Building CXX object tools\lldb\source\Plugins\LanguageRuntime\ObjC\AppleObjCRuntime\CMakeFiles\lldbPluginAppleObjCRuntime.dir\AppleObjCTrampolineHandler.cpp.obj
465.145 [198/34/5196]Building CXX object tools\lldb\source\Plugins\SystemRuntime\MacOSX\CMakeFiles\lldbPluginSystemRuntimeMacOSX.dir\AppleGetItemInfoHandler.cpp.obj
465.666 [198/33/5197]Building CXX object tools\lldb\source\Plugins\Language\ObjC\CMakeFiles\lldbPluginObjCLanguage.dir\NSDictionary.cpp.obj
465.882 [198/32/5198]Building CXX object tools\lldb\source\Plugins\ExpressionParser\Clang\CMakeFiles\lldbPluginExpressionParserClang.dir\ClangFunctionCaller.cpp.obj
465.951 [198/31/5199]Building CXX object tools\lldb\source\Plugins\ExpressionParser\Clang\CMakeFiles\lldbPluginExpressionParserClang.dir\ClangPersistentVariables.cpp.obj

```

</details>

https://github.com/llvm/llvm-project/pull/135808