[clang] [CodeGen] Fix new-delete-type-mismatch in ~CodeGenTypes() (PR #135787)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 15 06:33:31 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: mikit (m1kit)
<details>
<summary>Changes</summary>
It is undefined behavior to use `delete` expression on something which was not created with corresponding `new` expression. Switching to explicit global `operator delete()` call to match with `operator new()` call at `CGFunctionInfo::create()`.
This issue is raised by Chromium ClusterFuzz, with ASan enabled. https://crbug.com/410141973
---
Full diff: https://github.com/llvm/llvm-project/pull/135787.diff
1 Files Affected:
- (modified) clang/lib/CodeGen/CodeGenTypes.cpp (+1-1)
``````````diff
diff --git a/clang/lib/CodeGen/CodeGenTypes.cpp b/clang/lib/CodeGen/CodeGenTypes.cpp
index b94c11802a268..dec3b087b107f 100644
--- a/clang/lib/CodeGen/CodeGenTypes.cpp
+++ b/clang/lib/CodeGen/CodeGenTypes.cpp
@@ -41,7 +41,7 @@ CodeGenTypes::CodeGenTypes(CodeGenModule &cgm)
CodeGenTypes::~CodeGenTypes() {
for (llvm::FoldingSet<CGFunctionInfo>::iterator
I = FunctionInfos.begin(), E = FunctionInfos.end(); I != E; )
- delete &*I++;
+ operator delete(&*I++);
}
CGCXXABI &CodeGenTypes::getCXXABI() const { return getCGM().getCXXABI(); }
``````````
</details>
https://github.com/llvm/llvm-project/pull/135787
More information about the cfe-commits
mailing list