[clang] [SYCL] Basic code generation for SYCL kernel caller offload entry point functions. (PR #133030)
Tom Honermann via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 14 11:52:31 PDT 2025
================
@@ -732,6 +732,16 @@ CodeGenTypes::arrangeBuiltinFunctionDeclaration(CanQualType resultType,
RequiredArgs::All);
}
+const CGFunctionInfo &
+CodeGenTypes::arrangeSYCLKernelCallerDeclaration(QualType resultType,
+ const FunctionArgList &args) {
+ auto argTypes = getArgTypesForDeclaration(Context, args);
----------------
tahonermann wrote:
I don't think these uses violate the LLVM coding standard. The relevant guidelines are linked below.
- https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable
- https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto
It looks to me like `getArgTypesForDeclaration()` follows NRVO, so copies should be avoided.
https://github.com/llvm/llvm-project/pull/133030
More information about the cfe-commits
mailing list