[clang] [Clang][Sema]:Fix musttail attribute on a function with not_tail_called attribute has no warning/error (PR #134465)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 14 09:46:02 PDT 2025


AaronBallman wrote:

> @erichkeane @AaronBallman This is my first time participating in an open source project. 

Welcome!

> I would like to ask if you have the same opinion so far. I have revised many versions over and over again. I just hope that the requirements can be clarified.

FWIW, our process is to keep iterating on the review until all the active reviewers (people leaving comments) are happy with it it. That sometimes takes a number of iterations, especially as we "polish" a review up to make it production-quality. So this kind of back-and-forth is pretty typical, even if it can be a bit frustrating.

https://github.com/llvm/llvm-project/pull/134465


More information about the cfe-commits mailing list