[clang] Remove the redundant check for "WeakPtr" in isSmartPtrClass to fix the issue 135612. (PR #135629)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 14 07:50:49 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Ryosuke Niwa (rniwa)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/135629.diff
1 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp (+1-1)
``````````diff
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
index 781b0de5abd2f..134afcd124526 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
@@ -127,7 +127,7 @@ bool isCheckedPtr(const std::string &Name) {
bool isSmartPtrClass(const std::string &Name) {
return isRefType(Name) || isCheckedPtr(Name) || isRetainPtr(Name) ||
- Name == "WeakPtr" || Name == "WeakPtr" || Name == "WeakPtrFactory" ||
+ Name == "WeakPtr" || Name == "WeakPtrFactory" ||
Name == "WeakPtrFactoryWithBitField" || Name == "WeakPtrImplBase" ||
Name == "WeakPtrImplBaseSingleThread" || Name == "ThreadSafeWeakPtr" ||
Name == "ThreadSafeWeakOrStrongPtr" ||
``````````
</details>
https://github.com/llvm/llvm-project/pull/135629
More information about the cfe-commits
mailing list