[clang] [Clang][Sema]:Fix musttail attribute on a function with not_tail_called attribute has no warning/error (PR #134465)

[Erich Keane via cfe-commits]

================
@@ -717,6 +717,12 @@ bool Sema::checkMustTailAttr(const Stmt *St, const Attr &MTA) {
     return false;
   }
 
+  if (const FunctionDecl *CalleeDecl = CE->getDirectCallee();
+      CalleeDecl && CalleeDecl->hasAttr<NotTailCalledAttr>()) {
+    Diag(St->getBeginLoc(), diag::err_musttail_mismatch) << true << CalleeDecl;
+    return false;
----------------
erichkeane wrote:

Strange here:  We typically do a 'return true' in check functions on failure, so surprised this is a return false, but i see everywhere here does it.

https://github.com/llvm/llvm-project/pull/134465