[clang-tools-extra] [clang-doc][NFC] clean unused variable in HTML generator (PR #135505)
via cfe-commits
cfe-commits at lists.llvm.org
Sat Apr 12 15:12:57 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-tools-extra
Author: Mohamed Emad (hulxv)
<details>
<summary>Changes</summary>
While reading the code, I found some dead variables that are not used anymore but it still declared without removing them. I think it should be removed.
CC @<!-- -->ilovepi @<!-- -->petrhosek
---
Full diff: https://github.com/llvm/llvm-project/pull/135505.diff
1 Files Affected:
- (modified) clang-tools-extra/clang-doc/HTMLGenerator.cpp (-4)
``````````diff
diff --git a/clang-tools-extra/clang-doc/HTMLGenerator.cpp b/clang-tools-extra/clang-doc/HTMLGenerator.cpp
index cb10f16804024..aceb83e8c4c57 100644
--- a/clang-tools-extra/clang-doc/HTMLGenerator.cpp
+++ b/clang-tools-extra/clang-doc/HTMLGenerator.cpp
@@ -716,7 +716,6 @@ genHTML(const EnumInfo &I, const ClangDocContext &CDCtx) {
maybeWriteSourceFileRef(Out, CDCtx, I.DefLoc);
- std::string Description;
if (!I.Description.empty())
Out.emplace_back(genHTML(I.Description));
@@ -759,7 +758,6 @@ genHTML(const FunctionInfo &I, const ClangDocContext &CDCtx,
maybeWriteSourceFileRef(Out, CDCtx, I.DefLoc);
- std::string Description;
if (!I.Description.empty())
Out.emplace_back(genHTML(I.Description));
@@ -777,7 +775,6 @@ genHTML(const NamespaceInfo &I, Index &InfoIndex, const ClangDocContext &CDCtx,
Out.emplace_back(std::make_unique<TagNode>(HTMLTag::TAG_H1, InfoTitle));
- std::string Description;
if (!I.Description.empty())
Out.emplace_back(genHTML(I.Description));
@@ -820,7 +817,6 @@ genHTML(const RecordInfo &I, Index &InfoIndex, const ClangDocContext &CDCtx,
maybeWriteSourceFileRef(Out, CDCtx, I.DefLoc);
- std::string Description;
if (!I.Description.empty())
Out.emplace_back(genHTML(I.Description));
``````````
</details>
https://github.com/llvm/llvm-project/pull/135505
More information about the cfe-commits
mailing list