[clang] [CIR] Upstream binary assignments and comma (PR #135115)

[Morris Hafner via cfe-commits]

================
@@ -219,6 +219,13 @@ void CIRGenFunction::emitStoreOfScalar(mlir::Value value, Address addr,
   assert(!cir::MissingFeatures::opTBAA());
 }
 
+void CIRGenFunction::emitStoreThroughBitfieldLValue(RValue src, LValue dst,
+                                                    mlir::Value &result) {
----------------
mmha wrote:

I don't and you raise a good point. OGCG uses a `llvm::Value **` here as an optional return value and it makes sense there because that results in fewer dead instruction emitted if the result is discarded but for CIR that doesn't apply.

I changed the signature.

https://github.com/llvm/llvm-project/pull/135115