[clang] [alpha.webkit.RetainPtrCtorAdoptChecker] An assortment of small enhancements (PR #135329)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/lib/StaticAnalyzer/Checkers/WebKit/RetainPtrCtorAdoptChecker.cpp clang/test/Analysis/Checkers/WebKit/objc-mock-types.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/RetainPtrCtorAdoptChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/RetainPtrCtorAdoptChecker.cpp
index 348dc9752..264b7928a 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/RetainPtrCtorAdoptChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/RetainPtrCtorAdoptChecker.cpp
@@ -125,11 +125,11 @@ public:
     return isAdoptFnName(safeGetName(FnDecl));
   }
 
-  bool isAdoptFnName(const std::string& Name) const {
+  bool isAdoptFnName(const std::string &Name) const {
     return isAdoptNS(Name) || Name == "adoptCF" || Name == "adoptCFArc";
   }
 
-  bool isAdoptNS(const std::string& Name) const {
+  bool isAdoptNS(const std::string &Name) const {
     return Name == "adoptNS" || Name == "adoptNSArc";
   }
 
@@ -165,7 +165,7 @@ public:
     checkCreateOrCopyFunction(CE, DeclWithIssue);
   }
 
-  void checkAdoptCall(const CallExpr *CE, const std::string& FnName,
+  void checkAdoptCall(const CallExpr *CE, const std::string &FnName,
                       const Decl *DeclWithIssue) const {
     if (!CE->getNumArgs())
       return;
@@ -259,20 +259,21 @@ public:
         if (ParamDecl->hasAttr<CFReturnsRetainedAttr>())
           CreateOrCopyOutArguments.insert(Decl);
       } else {
-        // No callee or a variadic argument. Conservatively assume it's an out argument.
+        // No callee or a variadic argument. Conservatively assume it's an out
+        // argument.
         if (RTC.isUnretained(Decl->getType()))
           CreateOrCopyOutArguments.insert(Decl);
       }
     }
     auto Summary = Summaries->getSummary(AnyCall(CE));
     switch (Summary->getRetEffect().getKind()) {
-      case RetEffect::OwnedSymbol:
-      case RetEffect::OwnedWhenTrackedReceiver:
-        if (!CreateOrCopyFnCall.contains(CE))
-          reportLeak(CE, DeclWithIssue);
-        break;
-      default:
-        break;
+    case RetEffect::OwnedSymbol:
+    case RetEffect::OwnedWhenTrackedReceiver:
+      if (!CreateOrCopyFnCall.contains(CE))
+        reportLeak(CE, DeclWithIssue);
+      break;
+    default:
+      break;
     }
   }
 
@@ -340,7 +341,7 @@ public:
     else if (isCreateOrCopy(Arg))
       reportLeak(Name, CE, DeclWithIssue);
   }
-  
+
   void visitVarDecl(const VarDecl *VD) const {
     auto *Init = VD->getInit();
     if (!Init || !RTC.isARCEnabled())
@@ -446,7 +447,7 @@ public:
     auto *Receiver = ObjCMsgExpr->getInstanceReceiver()->IgnoreParenCasts();
     if (!Receiver)
       return false;
-  if (auto *Inner = dyn_cast<ObjCMessageExpr>(Receiver)) {
+    if (auto *Inner = dyn_cast<ObjCMessageExpr>(Receiver)) {
       if (InnerExpr)
         *InnerExpr = Inner;
       auto InnerSelector = Inner->getSelector();

``````````

</details>


https://github.com/llvm/llvm-project/pull/135329