[clang] [OpenACC][CIR] Implement 'device_type' clause lowering for 'init'/'sh… (PR #135102)

[Andy Kaylor via cfe-commits]

================
@@ -585,15 +585,16 @@ class CIRGenFunction : public CIRGenTypeCache {
 private:
   template <typename Op>
   mlir::LogicalResult
-  emitOpenACCOp(mlir::Location start,
+  emitOpenACCOp(OpenACCDirectiveKind dirKind, SourceLocation dirLoc,
+                mlir::Location start,
----------------
andykaylor wrote:

I don't like how inconsistent we've been about the placement of the location parameter. I thought there was a tendency in MLIR for it to be the first argument (though that felt odd to me). I just looked at the emit functions in the incubator and it's all over the place.

Do you think there's value in standardizing on it being the first argument?

https://github.com/llvm/llvm-project/pull/135102