[clang] [llvm] MCAsmStreamer: Replace the MCInstPrinter * parameter with unique_ptr (PR #135128)

Sergei Barannikov via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 10 08:27:15 PDT 2025


================
@@ -541,8 +542,8 @@ static bool ExecuteAssemblerImpl(AssemblerInvocation &Opts,
 
   // FIXME: There is a bit of code duplication with addPassesToEmitFile.
   if (Opts.OutputType == AssemblerInvocation::FT_Asm) {
-    MCInstPrinter *IP = TheTarget->createMCInstPrinter(
-        llvm::Triple(Opts.Triple), Opts.OutputAsmVariant, *MAI, *MCII, *MRI);
+    std::unique_ptr<MCInstPrinter> IP(TheTarget->createMCInstPrinter(
----------------
s-barannikov wrote:

(no action required) I wish `createMCInstPrinter` returned `unique_ptr`.


https://github.com/llvm/llvm-project/pull/135128


More information about the cfe-commits mailing list