[clang] [llvm] [LLVM][Clang][Cygwin] Fix building Clang for Cygwin (PR #134494)

[via cfe-commits]

Mateusz =?utf-8?q?Mikuła?= <oss at mateuszmikula.dev>,
Mateusz =?utf-8?q?Mikuła?= <oss at mateuszmikula.dev>,
Mateusz =?utf-8?q?Mikuła?= <oss at mateuszmikula.dev>,
Mateusz =?utf-8?q?Mikuła?= <oss at mateuszmikula.dev>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/134494 at github.com>


================
@@ -29,7 +29,6 @@
 #ifdef __CYGWIN__
 #include <cygwin/version.h>
 #include <sys/cygwin.h>
-#define _WIN32 1
 #endif
----------------
jeremyd2019 wrote:

I'd bet you could get rid of the entire `#ifdef __CYGWIN__` block here, and the code inside both `_WIN32` and `__CYGWIN__` below.  This code doesn't need to convert paths anymore, dladdr takes care of it.  Unless somebody cares about supporting older cygwin that didn't have dladdr?

https://github.com/llvm/llvm-project/pull/134494