[clang] [clang][DependencyScanning] Track dependencies from prebuilt modules to determine IsInStableDir (PR #132237)

Jan Svoboda via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 8 09:19:13 PDT 2025


================
@@ -2616,6 +2616,18 @@ bool ASTReader::shouldDisableValidationForFile(
   return false;
 }
 
+namespace {
+
+std::pair<StringRef, StringRef>
+getUnresolvedInputFilenames(const ASTReader::RecordData &Record,
----------------
jansvoboda11 wrote:

Nit: Per [LLVM Coding Standards](https://llvm.org/docs/CodingStandards.html#id59), this should be `static` instead of wrapped inside an anonymous namespace:
> make anonymous namespaces as small as possible, and only use them for class declarations

https://github.com/llvm/llvm-project/pull/132237


More information about the cfe-commits mailing list