[clang] [llvm] [IR] Mark convergence intrins as has-side-effect (PR #134844)

[Nathan Gauër via cfe-commits]

Keenuts wrote:

> Turns out not really, I ran spec with this about 2 years ago and the only non-noise change was a mild improvement

Looking at the PR you linked, seems like there was still not a clear consensus on the default change no? (And I'd assume consumers like llvm-translator won't be too happy about this breaking change no?)

> This is still trying to fix this in a roundabout way. You should be stopping the strip of the convergent attribute, not the intrinsic uses that happen to be in the function

Fair enough, sent another PR which handles this by fixing the FunctionAttr pass, preventing removal of the convergent attr in those cases.


https://github.com/llvm/llvm-project/pull/134844