[clang] [llvm] [clang][OpenMP][SPIR-V] Fix addrspace of globals and global constants (PR #134399)
Alex Voicu via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 8 07:54:53 PDT 2025
================
@@ -37,8 +37,8 @@ static const unsigned SPIRDefIsPrivMap[] = {
0, // cuda_device
0, // cuda_constant
0, // cuda_shared
- // SYCL address space values for this map are dummy
- 0, // sycl_global
+ // Most SYCL address space values for this map are dummy
----------------
AlexVlx wrote:
This is a hack for OpenCL, and is not meant to work otherwise, it should only be used for OCL (looks like an unfortunate import from some brainrot we put in AMDGPU). We've made an effort to fix this recently, so perhaps we could look at moving SPIR-V away from it as well, see #112442 and its children.
https://github.com/llvm/llvm-project/pull/134399
More information about the cfe-commits
mailing list