[clang] [clang-tools-extra] [clang] Do not share ownership of `PreprocessorOptions` (PR #133467)

LLVM Continuous Integration via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 4 11:49:32 PDT 2025 

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang-tools-extra,clang` at step 7 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/27880

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (test-build-unified-tree-check-all) failure: test (failure)
...
.............................................................................................................................................................
----------------------------------------------------------------------
Ran 157 tests in 2.693s

OK
3.171 [370/58/23] Linking CXX executable bin/mlir-capi-ir-test
3.246 [369/58/24] Linking CXX executable bin/mlir-capi-execution-engine-test
3.262 [368/58/25] Linking CXX executable tools/mlir/unittests/ExecutionEngine/MLIRExecutionEngineTests
3.276 [367/58/26] Linking CXX executable bin/mlir-capi-pass-test
7.603 [366/58/27] Building CXX object tools/clang/unittests/Parse/CMakeFiles/ParseTests.dir/ParseHLSLRootSignatureTest.cpp.o
FAILED: tools/clang/unittests/Parse/CMakeFiles/ParseTests.dir/ParseHLSLRootSignatureTest.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/buildbot/premerge-monolithic-linux/build/tools/clang/unittests/Parse -I/build/buildbot/premerge-monolithic-linux/llvm-project/clang/unittests/Parse -I/build/buildbot/premerge-monolithic-linux/llvm-project/clang/include -I/build/buildbot/premerge-monolithic-linux/build/tools/clang/include -I/build/buildbot/premerge-monolithic-linux/build/include -I/build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include -I/build/buildbot/premerge-monolithic-linux/llvm-project/third-party/unittest/googletest/include -I/build/buildbot/premerge-monolithic-linux/llvm-project/third-party/unittest/googlemock/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT tools/clang/unittests/Parse/CMakeFiles/ParseTests.dir/ParseHLSLRootSignatureTest.cpp.o -MF tools/clang/unittests/Parse/CMakeFiles/ParseTests.dir/ParseHLSLRootSignatureTest.cpp.o.d -o tools/clang/unittests/Parse/CMakeFiles/ParseTests.dir/ParseHLSLRootSignatureTest.cpp.o -c /build/buildbot/premerge-monolithic-linux/llvm-project/clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp:9:
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/clang/include/clang/Basic/Diagnostic.h:17:
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/clang/include/clang/Basic/DiagnosticIDs.h:18:
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/clang/include/clang/Basic/LLVM.h:21:
In file included from /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include/llvm/Support/Casting.h:20:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/memory:76:
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/unique_ptr.h:962:34: error: no matching constructor for initialization of 'clang::Preprocessor'
    { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
                                 ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/buildbot/premerge-monolithic-linux/llvm-project/clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp:87:45: note: in instantiation of function template specialization 'std::make_unique<clang::Preprocessor, std::shared_ptr<clang::PreprocessorOptions>, clang::DiagnosticsEngine &, clang::LangOptions &, clang::SourceManager &, clang::HeaderSearch &, clang::TrivialModuleLoader &, std::nullptr_t, bool>' requested here
    std::unique_ptr<Preprocessor> PP = std::make_unique<Preprocessor>(
                                            ^
/build/buildbot/premerge-monolithic-linux/llvm-project/clang/include/clang/Lex/Preprocessor.h:1168:3: note: candidate constructor not viable: no known conversion from 'std::shared_ptr<clang::PreprocessorOptions>' to 'const PreprocessorOptions' for 1st argument
  Preprocessor(const PreprocessorOptions &PPOpts, DiagnosticsEngine &diags,
  ^
/build/buildbot/premerge-monolithic-linux/llvm-project/clang/include/clang/Lex/Preprocessor.h:138:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 8 were provided
class Preprocessor {
      ^
1 error generated.
7.913 [366/57/28] Building CXX object tools/clang/unittests/Lex/CMakeFiles/LexTests.dir/PPConditionalDirectiveRecordTest.cpp.o
8.023 [366/56/29] Building CXX object tools/clang/unittests/Lex/CMakeFiles/LexTests.dir/PPMemoryAllocationsTest.cpp.o
8.729 [366/55/30] Building CXX object tools/clang/unittests/Lex/CMakeFiles/LexTests.dir/ModuleDeclStateTest.cpp.o
9.989 [366/54/31] Building CXX object tools/clang/unittests/Basic/CMakeFiles/BasicTests.dir/SourceManagerTest.cpp.o
10.046 [366/53/32] Building CXX object tools/clang/unittests/Lex/CMakeFiles/LexTests.dir/PPDependencyDirectivesTest.cpp.o
11.815 [366/52/33] Building CXX object tools/clang/unittests/Lex/CMakeFiles/LexTests.dir/LexerTest.cpp.o
12.761 [366/51/34] Building CXX object tools/clang/unittests/Serialization/CMakeFiles/SerializationTests.dir/ModuleCacheTest.cpp.o
13.428 [366/50/35] Building CXX object tools/clang/lib/Testing/CMakeFiles/clangTesting.dir/TestAST.cpp.o
13.807 [366/49/36] Building CXX object tools/clang/tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/IncludeSpellerTest.cpp.o
13.864 [366/48/37] Building CXX object tools/clang/tools/extra/unittests/clang-apply-replacements/CMakeFiles/ClangApplyReplacementsTests.dir/ApplyReplacementsTest.cpp.o
13.992 [366/47/38] Building CXX object tools/clang/unittests/Tooling/CMakeFiles/ToolingTests.dir/CommentHandlerTest.cpp.o
14.620 [366/46/39] Building CXX object tools/clang/unittests/Driver/CMakeFiles/ClangDriverTests.dir/DXCModeTest.cpp.o
14.629 [366/45/40] Building CXX object tools/clang/unittests/Analysis/CMakeFiles/ClangAnalysisTests.dir/CloneDetectionTest.cpp.o
15.708 [366/44/41] Building CXX object tools/clang/tools/extra/unittests/clang-doc/CMakeFiles/ClangDocTests.dir/YAMLGeneratorTest.cpp.o
15.990 [366/43/42] Building CXX object tools/clang/tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/WalkASTTest.cpp.o
16.547 [366/42/43] Building CXX object tools/clang/tools/extra/unittests/clang-include-fixer/CMakeFiles/ClangIncludeFixerTests.dir/IncludeFixerTest.cpp.o
16.603 [366/41/44] Building CXX object tools/clang/tools/extra/unittests/clang-doc/CMakeFiles/ClangDocTests.dir/ClangDocTest.cpp.o
16.738 [366/40/45] Building CXX object tools/clang/tools/extra/unittests/clang-doc/CMakeFiles/ClangDocTests.dir/GeneratorTest.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/133467

More information about the cfe-commits mailing list