[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)
Jack Styles via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 4 06:29:06 PDT 2025
================
@@ -659,13 +659,21 @@ llvm::ARM::FPUKind arm::getARMTargetFeatures(const Driver &D,
CPUArgFPUKind != llvm::ARM::FK_INVALID ? CPUArgFPUKind : ArchArgFPUKind;
(void)llvm::ARM::getFPUFeatures(FPUKind, Features);
} else {
+ bool Generic = true;
if (!ForAS) {
std::string CPU = arm::getARMTargetCPU(CPUName, ArchName, Triple);
+ if (CPU != "generic")
+ Generic = false;
llvm::ARM::ArchKind ArchKind =
arm::getLLVMArchKindForARM(CPU, ArchName, Triple);
FPUKind = llvm::ARM::getDefaultFPU(CPU, ArchKind);
(void)llvm::ARM::getFPUFeatures(FPUKind, Features);
}
+ if (Generic && (Triple.isOSWindows() || Triple.isOSDarwin()) &&
----------------
Stylie777 wrote:
```
+ bool Generic = "generic";
```
Did you try this as `bool Generic = CPU == "generic"`? I am not 100% what the behaviour as it is in the diff would work, I feel that would set Generic to always be true.
https://github.com/llvm/llvm-project/pull/122095
More information about the cfe-commits
mailing list