[clang-tools-extra] [NFC] Fixes proposed by code sanitizer. (PR #134138)

Zahira Ammarguellat via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 4 04:49:44 PDT 2025


zahiraam wrote:

> In general, I don't fully understand the scope of this patch. Surely, there's thousands of things that could be improved in the codebase. Which of those belong to this patch? Reviewers can always point out things that could be improved ad infinitum, leading to a patch with lots of unrelated changes. When do we decide that we are done?

I totally agree. Our code sanitizer points us to many edits that are most of the time false positive. I have proposed in this PR fixes that I have judged might be real issues (I might be wrong). 
As you suggested I have reverted the changes for clang-tidy. The 2 that are left are in `cland/Headers.cpp` and `clang/ConfigCompile.cpp`.  If you agree with the edits, please approve. If not I will close the PR.
Thanks.

https://github.com/llvm/llvm-project/pull/134138


More information about the cfe-commits mailing list