[clang] [clang] Add `__bf16` Type Support Macros With Literal Suffix Support (PR #134214)

via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 4 01:52:54 PDT 2025


================
@@ -978,6 +979,28 @@ NumericLiteralParser::NumericLiteralParser(StringRef TokSpelling,
   // we break out of the loop.
   for (; s != ThisTokEnd; ++s) {
     switch (*s) {
+    case 'b':
+    case 'B':
+      if (!isFPConstant)
+        break; // Error for integer constant.
+      if (isBFloat16)
+        break;
+      if (!Target.hasBFloat16Type())
+        break;
----------------
overmighty wrote:

Nit: I think target support for bfloat16 should be checked first. Some of the other `switch` cases start by checking `LangOpts`.

There's no need to check both `isBFloat16` and `HasSize`, we can just check `HasSize`.

```suggestion
      if (!Target.hasBFloat16Type())
        break;
      if (!isFPConstant)
        break; // Error for integer constant.
```

https://github.com/llvm/llvm-project/pull/134214


More information about the cfe-commits mailing list