[clang] [HLSL] Implement the `lit` intrinsic (PR #134171)

via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 3 15:12:14 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h -- clang/lib/Headers/hlsl.h clang/lib/Headers/hlsl/hlsl_compat_overloads.h clang/lib/Headers/hlsl/hlsl_intrinsic_helpers.h clang/lib/Headers/hlsl/hlsl_intrinsics.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Headers/hlsl/hlsl_intrinsic_helpers.h b/clang/lib/Headers/hlsl/hlsl_intrinsic_helpers.h
index c3e5b105f..3a41635a8 100644
--- a/clang/lib/Headers/hlsl/hlsl_intrinsic_helpers.h
+++ b/clang/lib/Headers/hlsl/hlsl_intrinsic_helpers.h
@@ -105,7 +105,7 @@ template <typename T> constexpr vector<T, 4> lit_impl(T NDotL, T NDotH, T M) {
   bool DiffuseCond = NDotL < 0;
   T Diffuse = select<T>(DiffuseCond, 0, NDotL);
   vector<T, 4> Result = {1, Diffuse, 0, 1};
-  bool SpecularCond = or(DiffuseCond, (NDotH < 0));
+  bool SpecularCond = or (DiffuseCond, (NDotH < 0));
   T SpecularExp = exp(log(NDotH) * M);
   Result[2] = select<T>(SpecularCond, 0, SpecularExp);
   return Result;

``````````

</details>


https://github.com/llvm/llvm-project/pull/134171


More information about the cfe-commits mailing list