[clang] [CLANG-CL] ignores wpadded (PR #130182)

Alex Bradbury via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 3 06:09:00 PDT 2025


=?utf-8?q?Théo?= De Magalhaes <theo.de-magalhaes at epita.fr>,
=?utf-8?q?Théo?= De Magalhaes <theo.de-magalhaes at epita.fr>,
=?utf-8?q?Théo?= De Magalhaes <theo.de-magalhaes at epita.fr>,
=?utf-8?q?Théo?= De Magalhaes <theo.de-magalhaes at epita.fr>,
=?utf-8?q?Théo?= De Magalhaes <theo.de-magalhaes at epita.fr>,
=?utf-8?q?Théo?= De Magalhaes <theo.de-magalhaes at epita.fr>,
=?utf-8?q?Théo?= De Magalhaes <theo.de-magalhaes at epita.fr>,
=?utf-8?q?Théo?= De Magalhaes <theo.de-magalhaes at epita.fr>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/130182 at github.com>


================
@@ -3004,6 +3010,15 @@ void MicrosoftRecordLayoutBuilder::layoutField(const FieldDecl *FD) {
   } else {
     FieldOffset = Size.alignTo(Info.Alignment);
   }
+
+  uint64_t UnpaddedFielddOffsetInBits =
+      Context.toBits(DataSize) - RemainingBitsInField;
----------------
asb wrote:

This is unfortunately a little non-obvious when someone else lands your patch. It is mentioned in the automated message above about landing your first PR - see the guidance here https://llvm.org/docs/MyFirstTypoFix.html#myfirsttypofix-issues-after-landing-your-pr Basically once it's committed, check the buildbot console.

Emails should go out from failing bots, but it may be that email go just to the committer and you don't get them.

https://github.com/llvm/llvm-project/pull/130182


More information about the cfe-commits mailing list