[clang] [CMAKE][AMDGPU] fix build failure caused by PR #133619 (PR #133776)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 31 11:47:57 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Farzon Lotfi (farzonl)
<details>
<summary>Changes</summary>
While clangCodeGenTargetBuiltins and clangCodeGenTargets are static libraries clangCodeGen is not and so this is creating a circular reference in the linux amdgpu-offload CIs on ubuntu and RHEL.
removing the circular reference doesn't break anything and looks to be a vestigial element of the origional PR.
---
Full diff: https://github.com/llvm/llvm-project/pull/133776.diff
2 Files Affected:
- (modified) clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt (-5)
- (modified) clang/lib/CodeGen/Targets/CMakeLists.txt (-5)
``````````diff
diff --git a/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt b/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt
index 8526c063b4593..76be68a11d02a 100644
--- a/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt
+++ b/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt
@@ -12,8 +12,3 @@ add_clang_library(clangCodeGenTargetBuiltins STATIC
WebAssembly.cpp
X86.cpp
)
-
-target_link_libraries(clangCodeGenTargetBuiltins
- PRIVATE
- clangCodeGen
-)
diff --git a/clang/lib/CodeGen/Targets/CMakeLists.txt b/clang/lib/CodeGen/Targets/CMakeLists.txt
index fd79b6191b379..6b6e7ce5b0b29 100644
--- a/clang/lib/CodeGen/Targets/CMakeLists.txt
+++ b/clang/lib/CodeGen/Targets/CMakeLists.txt
@@ -28,8 +28,3 @@ add_clang_library(clangCodeGenTargets STATIC
X86.cpp
XCore.cpp
)
-
-target_link_libraries(clangCodeGenTargets
- PRIVATE
- clangCodeGen
-)
``````````
</details>
https://github.com/llvm/llvm-project/pull/133776
More information about the cfe-commits
mailing list