[clang] [CIR] Upstream CmpOp (PR #133159)

Andy Kaylor via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 31 10:37:30 PDT 2025


================
@@ -514,9 +515,17 @@ mlir::LogicalResult CIRToLLVMCastOpLowering::matchAndRewrite(
     assert(!MissingFeatures::cxxABI());
     assert(!MissingFeatures::dataMemberType());
     break;
-  case cir::CastKind::ptr_to_bool:
-    assert(!cir::MissingFeatures::opCmp());
+  case cir::CastKind::ptr_to_bool: {
----------------
andykaylor wrote:

As far as I know, there is no additional benefit to going through the cir ops.

@bcardosolopes Can you comment on this?

https://github.com/llvm/llvm-project/pull/133159


More information about the cfe-commits mailing list