[clang] [Clang][RFC] Bypass TAD during overload resolution if a perfect match exists (PR #133426)

[via cfe-commits]

================
@@ -10918,7 +11083,44 @@ bool OverloadCandidate::NotValidBecauseConstraintExprHasError() const {
 OverloadingResult
 OverloadCandidateSet::BestViableFunction(Sema &S, SourceLocation Loc,
                                          iterator &Best) {
+
+  bool TwoPhaseResolution =
+      !NonDeducedCandidates.empty() && Kind != CSK_CodeCompletion &&
+      Kind != CSK_InitByUserDefinedConversion && Kind != CSK_InitByConstructor;
+
+  if (TwoPhaseResolution) {
+    Best = end();
+    for (auto It = begin(); It != end(); ++It) {
+      if (It->isPerfectMatch(S.getASTContext())) {
+        if (Best == end()) {
+          Best = It;
+        } else {
+          Best = end();
+          break;
+        }
+      }
+    }
+    if (Best != end()) {
+      Best->Best = true;
+      if (Best->Function && Best->Function->isDeleted())
+        return OR_Deleted;
+      if (auto *M = dyn_cast_or_null<CXXMethodDecl>(Best->Function);
+          Kind == CSK_AddressOfOverloadSet && M &&
+          M->isImplicitObjectMemberFunction()) {
+        return OR_No_Viable_Function;
----------------
cor3ntin wrote:

It was pre-existing but also... not great. I moved it to  `BuildOverloadedCallExpr` and commented

https://github.com/llvm/llvm-project/pull/133426