[clang] [clang] Do not share ownership of `HeaderSearchOptions` (PR #132984)

[Ben Langmuir via cfe-commits]

================
@@ -569,7 +569,7 @@ CrossTranslationUnitContext::ASTLoader::loadFromDump(StringRef ASTDumpPath) {
   return ASTUnit::LoadFromASTFile(
       ASTDumpPath, CI.getPCHContainerOperations()->getRawReader(),
       ASTUnit::LoadEverything, Diags, CI.getFileSystemOpts(),
-      CI.getHeaderSearchOptsPtr());
+      CI.getHeaderSearchOpts());
----------------
benlangmuir wrote:

@Xazax-hun  I think this change would mean that LoadFromASTFile would no longer modify the header search options on CI here. I'm not familiar with the CrossTU code; do you know if that is okay?

https://github.com/llvm/llvm-project/pull/132984