[clang] [clang] Fix the crash when dumping deserialized decls (PR #133395)

Ilya Biryukov via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 28 03:10:25 PDT 2025


================
@@ -57,6 +59,8 @@ class ASTDeserializationListener {
   /// A module import was read from the AST file.
   virtual void ModuleImportRead(serialization::SubmoduleID ID,
                                 SourceLocation ImportLoc) {}
+  /// The deserialization of the AST file was finished.
----------------
ilya-biryukov wrote:

Could we document that while causing more serialization in the callbacks may have complicated side-effects and the implementors should be careful?

I believe it's a very non-trivial details that folks reading the code should be warned about.

https://github.com/llvm/llvm-project/pull/133395


More information about the cfe-commits mailing list