[clang] 64046e9 - [Driver] Use a range constructor of StringSet (NFC) (#133201)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 26 20:54:11 PDT 2025
Author: Kazu Hirata
Date: 2025-03-26T20:54:08-07:00
New Revision: 64046e9d2628ce421682eea8465e41554b46c96d
URL: https://github.com/llvm/llvm-project/commit/64046e9d2628ce421682eea8465e41554b46c96d
DIFF: https://github.com/llvm/llvm-project/commit/64046e9d2628ce421682eea8465e41554b46c96d.diff
LOG: [Driver] Use a range constructor of StringSet (NFC) (#133201)
This patch uses a range constructor to collapse:
llvm::StringSet<> Dest;
for (const auto &S : Src)
Dest.insert(S);
down to:
llvm::StringSet<> Dest(llvm::from_range, Src);
Added:
Modified:
clang/lib/Driver/Job.cpp
clang/lib/Driver/Multilib.cpp
Removed:
################################################################################
diff --git a/clang/lib/Driver/Job.cpp b/clang/lib/Driver/Job.cpp
index ae2f1cd1f56c9..4619b8c1887be 100644
--- a/clang/lib/Driver/Job.cpp
+++ b/clang/lib/Driver/Job.cpp
@@ -140,9 +140,7 @@ void Command::buildArgvForResponseFile(
return;
}
- llvm::StringSet<> Inputs;
- for (const auto *InputName : InputFileList)
- Inputs.insert(InputName);
+ llvm::StringSet<> Inputs(llvm::from_range, InputFileList);
Out.push_back(Executable);
if (PrependArg)
diff --git a/clang/lib/Driver/Multilib.cpp b/clang/lib/Driver/Multilib.cpp
index a92ad4718fb6e..87fa1af54a8ea 100644
--- a/clang/lib/Driver/Multilib.cpp
+++ b/clang/lib/Driver/Multilib.cpp
@@ -60,9 +60,7 @@ void Multilib::print(raw_ostream &OS) const {
bool Multilib::operator==(const Multilib &Other) const {
// Check whether the flags sets match
// allowing for the match to be order invariant
- llvm::StringSet<> MyFlags;
- for (const auto &Flag : Flags)
- MyFlags.insert(Flag);
+ llvm::StringSet<> MyFlags(llvm::from_range, Flags);
for (const auto &Flag : Other.Flags)
if (!MyFlags.contains(Flag))
@@ -272,9 +270,7 @@ bool MultilibSet::select(
llvm::StringSet<>
MultilibSet::expandFlags(const Multilib::flags_list &InFlags) const {
- llvm::StringSet<> Result;
- for (const auto &F : InFlags)
- Result.insert(F);
+ llvm::StringSet<> Result(llvm::from_range, InFlags);
for (const FlagMatcher &M : FlagMatchers) {
std::string RegexString(M.Match);
More information about the cfe-commits
mailing list