[clang] [CIR] Upstream CmpOp (PR #133159)

[Andy Kaylor via cfe-commits]

================
@@ -514,9 +515,17 @@ mlir::LogicalResult CIRToLLVMCastOpLowering::matchAndRewrite(
     assert(!MissingFeatures::cxxABI());
     assert(!MissingFeatures::dataMemberType());
     break;
-  case cir::CastKind::ptr_to_bool:
-    assert(!cir::MissingFeatures::opCmp());
+  case cir::CastKind::ptr_to_bool: {
----------------
andykaylor wrote:

Can this lower directly to LLVM comparison like I just did for int_to_bool? Is anything added by going through the cir comparison?

https://github.com/llvm/llvm-project/pull/133159