[clang] [clang-tools-extra] [clang] Consistently use "load" to refer to populating clang::ModuleMap (PR #132970)

Tue Mar 25 12:41:42 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang-tools-extra,clang` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/14192

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-unified-tree) failure: build (failure)
...
[4105/4859] Building CXX object tools\clang\tools\extra\clang-tidy\readability\CMakeFiles\obj.clangTidyReadabilityModule.dir\DeleteNullPointerCheck.cpp.obj
[4106/4859] Building CXX object tools\clang\lib\StaticAnalyzer\Checkers\CMakeFiles\obj.clangStaticAnalyzerCheckers.dir\WebKit\RawPtrRefLocalVarsChecker.cpp.obj
[4107/4859] Building CXX object tools\clang\tools\extra\clang-reorder-fields\CMakeFiles\obj.clangReorderFields.dir\ReorderFieldsAction.cpp.obj
[4108/4859] Building CXX object tools\clang\tools\extra\clang-tidy\readability\CMakeFiles\obj.clangTidyReadabilityModule.dir\EnumInitialValueCheck.cpp.obj
[4109/4859] Building CXX object tools\clang\tools\extra\clang-tidy\readability\CMakeFiles\obj.clangTidyReadabilityModule.dir\FunctionCognitiveComplexityCheck.cpp.obj
[4110/4859] Linking CXX static library lib\clangReorderFields.lib
[4111/4859] Building CXX object tools\clang\tools\extra\clang-tidy\readability\CMakeFiles\obj.clangTidyReadabilityModule.dir\FunctionSizeCheck.cpp.obj
[4112/4859] Building CXX object tools\clang\tools\extra\clang-tidy\readability\CMakeFiles\obj.clangTidyReadabilityModule.dir\IdentifierLengthCheck.cpp.obj
[4113/4859] Building CXX object tools\clang\lib\StaticAnalyzer\Checkers\CMakeFiles\obj.clangStaticAnalyzerCheckers.dir\WebKit\ForwardDeclChecker.cpp.obj
[4114/4859] Building CXX object tools\clang\tools\extra\modularize\CMakeFiles\modularize.dir\ModularizeUtilities.cpp.obj
FAILED: tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/ModularizeUtilities.cpp.obj 
C:\bin\ccache.exe C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DCLANG_BUILD_STATIC -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\clang\tools\extra\modularize -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\clang-tools-extra\modularize -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\include -Itools\clang\include -Iinclude -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -wd4251 -wd4275 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Fotools\clang\tools\extra\modularize\CMakeFiles\modularize.dir\ModularizeUtilities.cpp.obj /Fdtools\clang\tools\extra\modularize\CMakeFiles\modularize.dir\ /FS -c Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang-tools-extra\modularize\ModularizeUtilities.cpp
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang-tools-extra\modularize\ModularizeUtilities.cpp(293): error C2039: 'parseModuleMapFile': is not a member of 'clang::ModuleMap'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\include\clang/Lex/ModuleMap.h(74): note: see declaration of 'clang::ModuleMap'
[4115/4859] Building CXX object tools\clang\tools\extra\clang-tidy\readability\CMakeFiles\obj.clangTidyReadabilityModule.dir\ImplicitBoolConversionCheck.cpp.obj
[4116/4859] Linking CXX executable bin\clang-import-test.exe
[4117/4859] Building CXX object tools\clang\tools\clang-diff\CMakeFiles\clang-diff.dir\ClangDiff.cpp.obj
[4118/4859] Building CXX object tools\clang\tools\clang-extdef-mapping\CMakeFiles\clang-extdef-mapping.dir\ClangExtDefMapGen.cpp.obj
[4119/4859] Building CXX object tools\clang\tools\clang-check\CMakeFiles\clang-check.dir\ClangCheck.cpp.obj
[4120/4859] Linking CXX executable bin\clang-reorder-fields.exe
[4121/4859] Building CXX object tools\clang\tools\extra\clang-apply-replacements\CMakeFiles\obj.clangApplyReplacements.dir\lib\Tooling\ApplyReplacements.cpp.obj
[4122/4859] Building CXX object tools\clang\tools\clang-installapi\CMakeFiles\clang-installapi.dir\ClangInstallAPI.cpp.obj
[4123/4859] Building CXX object tools\clang\tools\extra\clang-tidy\cppcoreguidelines\CMakeFiles\obj.clangTidyCppCoreGuidelinesModule.dir\InitVariablesCheck.cpp.obj
[4124/4859] Building CXX object tools\clang\tools\extra\clang-tidy\cppcoreguidelines\CMakeFiles\obj.clangTidyCppCoreGuidelinesModule.dir\MacroUsageCheck.cpp.obj
[4125/4859] Building CXX object tools\clang\tools\extra\clang-tidy\CMakeFiles\obj.clangTidy.dir\ExpandModularHeadersPPCallbacks.cpp.obj
[4126/4859] Building CXX object tools\clang\tools\extra\clang-tidy\bugprone\CMakeFiles\obj.clangTidyBugproneModule.dir\BadSignalToKillThreadCheck.cpp.obj
[4127/4859] Building CXX object tools\clang\tools\extra\clang-apply-replacements\tool\CMakeFiles\clang-apply-replacements.dir\ClangApplyReplacementsMain.cpp.obj
[4128/4859] Building CXX object tools\clang\tools\extra\clang-tidy\bugprone\CMakeFiles\obj.clangTidyBugproneModule.dir\UnsafeFunctionsCheck.cpp.obj
[4129/4859] Building CXX object tools\clang\tools\extra\clang-tidy\concurrency\CMakeFiles\obj.clangTidyConcurrencyModule.dir\ThreadCanceltypeAsynchronousCheck.cpp.obj
[4130/4859] Building CXX object tools\clang\tools\clang-repl\CMakeFiles\clang-repl.dir\ClangRepl.cpp.obj
[4131/4859] Building CXX object tools\clang\lib\StaticAnalyzer\Checkers\CMakeFiles\obj.clangStaticAnalyzerCheckers.dir\WebKit\RetainPtrCtorAdoptChecker.cpp.obj
[4132/4859] Building CXX object tools\clang\tools\extra\clang-tidy\readability\CMakeFiles\obj.clangTidyReadabilityModule.dir\AvoidUnconditionalPreprocessorIfCheck.cpp.obj
[4133/4859] Building CXX object tools\clang\tools\extra\clang-tidy\cppcoreguidelines\CMakeFiles\obj.clangTidyCppCoreGuidelinesModule.dir\ProTypeVarargCheck.cpp.obj
[4134/4859] Building CXX object tools\clang\tools\extra\clang-tidy\cert\CMakeFiles\obj.clangTidyCERTModule.dir\SetLongJmpCheck.cpp.obj
[4135/4859] Building CXX object tools\clang\tools\extra\clang-tidy\modernize\CMakeFiles\obj.clangTidyModernizeModule.dir\ReplaceAutoPtrCheck.cpp.obj
[4136/4859] Building CXX object tools\clang\tools\extra\clang-tidy\altera\CMakeFiles\obj.clangTidyAlteraModule.dir\KernelNameRestrictionCheck.cpp.obj
[4137/4859] Building CXX object tools\clang\tools\extra\clang-tidy\bugprone\CMakeFiles\obj.clangTidyBugproneModule.dir\LambdaFunctionNameCheck.cpp.obj
[4138/4859] Building CXX object tools\clang\tools\c-index-test\CMakeFiles\c-index-test.dir\core_main.cpp.obj
[4139/4859] Building CXX object tools\clang\tools\extra\clang-tidy\abseil\CMakeFiles\obj.clangTidyAbseilModule.dir\StringFindStartswithCheck.cpp.obj
[4140/4859] Building CXX object tools\clang\tools\extra\clang-tidy\google\CMakeFiles\obj.clangTidyGoogleModule.dir\TodoCommentCheck.cpp.obj
[4141/4859] Building CXX object tools\clang\tools\extra\clang-tidy\google\CMakeFiles\obj.clangTidyGoogleModule.dir\UpgradeGoogletestCaseCheck.cpp.obj
[4142/4859] Building CXX object tools\clang\tools\extra\clang-tidy\bugprone\CMakeFiles\obj.clangTidyBugproneModule.dir\MacroParenthesesCheck.cpp.obj
[4143/4859] Building CXX object tools\clang\tools\extra\clang-tidy\misc\CMakeFiles\obj.clangTidyMiscModule.dir\MiscTidyModule.cpp.obj
[4144/4859] Building CXX object tools\clang\tools\extra\clang-tidy\bugprone\CMakeFiles\obj.clangTidyBugproneModule.dir\SuspiciousIncludeCheck.cpp.obj
[4145/4859] Building CXX object tools\clang\tools\extra\clang-tidy\google\CMakeFiles\obj.clangTidyGoogleModule.dir\AvoidUnderscoreInGoogletestNameCheck.cpp.obj
[4146/4859] Building CXX object tools\clang\tools\extra\modularize\CMakeFiles\modularize.dir\CoverageChecker.cpp.obj
[4147/4859] Building CXX object tools\clang\tools\extra\clang-tidy\bugprone\CMakeFiles\obj.clangTidyBugproneModule.dir\NotNullTerminatedResultCheck.cpp.obj
[4148/4859] Building CXX object tools\clang\tools\clang-scan-deps\CMakeFiles\clang-scan-deps.dir\ClangScanDeps.cpp.obj
[4149/4859] Building CXX object tools\clang\tools\extra\clang-tidy\misc\CMakeFiles\obj.clangTidyMiscModule.dir\ConfusableIdentifierCheck.cpp.obj

```

</details>

https://github.com/llvm/llvm-project/pull/132970