[clang] [clang-tools-extra] [clang] Consistently use "load" to refer to populating clang::ModuleMap (PR #132970)

Tue Mar 25 12:39:35 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang-tools-extra,clang` at step 3 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/16245

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 3 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/hip-build.sh --jobs=' (failure)
...
[383/714] Building CXX object tools/clang/tools/extra/clang-apply-replacements/tool/CMakeFiles/clang-apply-replacements.dir/ClangApplyReplacementsMain.cpp.o
[384/714] Building CXX object tools/clang/lib/StaticAnalyzer/Checkers/CMakeFiles/obj.clangStaticAnalyzerCheckers.dir/WebKit/ForwardDeclChecker.cpp.o
[385/714] Building CXX object tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/InterpreterValuePrinter.cpp.o
[386/714] Building CXX object tools/clang/tools/clang-refactor/CMakeFiles/clang-refactor.dir/ClangRefactor.cpp.o
[387/714] Building CXX object tools/clang/tools/extra/clang-tidy/mpi/CMakeFiles/obj.clangTidyMPIModule.dir/MPITidyModule.cpp.o
[388/714] Building CXX object tools/clang/tools/extra/clang-apply-replacements/CMakeFiles/obj.clangApplyReplacements.dir/lib/Tooling/ApplyReplacements.cpp.o
[389/714] Linking CXX static library lib/libclangApplyReplacements.a
[390/714] Linking CXX executable bin/clang-apply-replacements
[391/714] Building CXX object tools/clang/lib/StaticAnalyzer/Checkers/CMakeFiles/obj.clangStaticAnalyzerCheckers.dir/WebKit/RetainPtrCtorAdoptChecker.cpp.o
[392/714] Building CXX object tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/ModularizeUtilities.cpp.o
FAILED: tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/ModularizeUtilities.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/clang-hip-vega20/botworker/clang-hip-vega20/llvm/tools/clang/tools/extra/modularize -I/home/botworker/bbot/clang-hip-vega20/llvm-project/clang-tools-extra/modularize -I/home/botworker/bbot/clang-hip-vega20/llvm-project/clang/include -I/home/botworker/bbot/clang-hip-vega20/botworker/clang-hip-vega20/llvm/tools/clang/include -I/home/botworker/bbot/clang-hip-vega20/botworker/clang-hip-vega20/llvm/include -I/home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/ModularizeUtilities.cpp.o -MF tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/ModularizeUtilities.cpp.o.d -o tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/ModularizeUtilities.cpp.o -c /home/botworker/bbot/clang-hip-vega20/llvm-project/clang-tools-extra/modularize/ModularizeUtilities.cpp
/home/botworker/bbot/clang-hip-vega20/llvm-project/clang-tools-extra/modularize/ModularizeUtilities.cpp: In member function ‘std::error_code Modularize::ModularizeUtilities::loadModuleMap(llvm::StringRef)’:
/home/botworker/bbot/clang-hip-vega20/llvm-project/clang-tools-extra/modularize/ModularizeUtilities.cpp:293:15: error: ‘class clang::ModuleMap’ has no member named ‘parseModuleMapFile’; did you mean ‘loadModuleMapFile’?
  293 |   if (ModMap->parseModuleMapFile(ModuleMapEntry, false, Dir)) {
      |               ^~~~~~~~~~~~~~~~~~
      |               loadModuleMapFile
[393/714] Linking CXX static library lib/libclangStaticAnalyzerCheckers.a
[394/714] Building CXX object tools/clang/tools/clang-installapi/CMakeFiles/clang-installapi.dir/ClangInstallAPI.cpp.o
[395/714] Building CXX object tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/CoverageChecker.cpp.o
[396/714] Linking CXX executable bin/clang-refactor
[397/714] Building CXX object tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ExpandModularHeadersPPCallbacks.cpp.o
[398/714] Building CXX object tools/clang/tools/clang-repl/CMakeFiles/clang-repl.dir/ClangRepl.cpp.o
[399/714] Building CXX object tools/clang/tools/clang-scan-deps/CMakeFiles/clang-scan-deps.dir/ClangScanDeps.cpp.o
[400/714] Building CXX object tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/Interpreter.cpp.o
[401/714] Linking CXX executable bin/clang-import-test
[402/714] Building CXX object tools/clang/tools/extra/clang-query/tool/CMakeFiles/clang-query.dir/ClangQuery.cpp.o
[403/714] Building CXX object tools/clang/tools/extra/clang-move/CMakeFiles/obj.clangMove.dir/HelperDeclRefGraph.cpp.o
[404/714] Building CXX object tools/clang/tools/extra/clang-reorder-fields/CMakeFiles/obj.clangReorderFields.dir/ReorderFieldsAction.cpp.o
[405/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/BadSignalToKillThreadCheck.cpp.o
[406/714] Building CXX object tools/clang/tools/extra/clang-tidy/altera/CMakeFiles/obj.clangTidyAlteraModule.dir/KernelNameRestrictionCheck.cpp.o
[407/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/LambdaFunctionNameCheck.cpp.o
[408/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/MacroParenthesesCheck.cpp.o
[409/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/MacroRepeatedSideEffectsCheck.cpp.o
[410/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/SuspiciousIncludeCheck.cpp.o
[411/714] Building CXX object tools/clang/tools/extra/clang-tidy/abseil/CMakeFiles/obj.clangTidyAbseilModule.dir/StringFindStartswithCheck.cpp.o
[412/714] Building CXX object tools/clang/tools/extra/clang-tidy/concurrency/CMakeFiles/obj.clangTidyConcurrencyModule.dir/ThreadCanceltypeAsynchronousCheck.cpp.o
[413/714] Building CXX object tools/clang/tools/extra/clang-tidy/cert/CMakeFiles/obj.clangTidyCERTModule.dir/SetLongJmpCheck.cpp.o
[414/714] Building CXX object tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/Modularize.cpp.o
[415/714] Building CXX object tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ClangTidy.cpp.o
[416/714] Building CXX object tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/InitVariablesCheck.cpp.o
[417/714] Building CXX object tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/MacroUsageCheck.cpp.o
[418/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/UnsafeFunctionsCheck.cpp.o
[419/714] Building CXX object tools/clang/tools/extra/clang-tidy/google/CMakeFiles/obj.clangTidyGoogleModule.dir/AvoidUnderscoreInGoogletestNameCheck.cpp.o
[420/714] Building CXX object tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProTypeVarargCheck.cpp.o
[421/714] Building CXX object tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProBoundsConstantArrayIndexCheck.cpp.o
[422/714] Building CXX object tools/clang/tools/extra/clang-tidy/google/CMakeFiles/obj.clangTidyGoogleModule.dir/TodoCommentCheck.cpp.o
[423/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/NotNullTerminatedResultCheck.cpp.o
[424/714] Building CXX object tools/clang/tools/extra/clang-tidy/google/CMakeFiles/obj.clangTidyGoogleModule.dir/UpgradeGoogletestCaseCheck.cpp.o
Step 7 (Building LLVM) failure: Building LLVM (failure)
...
[383/714] Building CXX object tools/clang/tools/extra/clang-apply-replacements/tool/CMakeFiles/clang-apply-replacements.dir/ClangApplyReplacementsMain.cpp.o
[384/714] Building CXX object tools/clang/lib/StaticAnalyzer/Checkers/CMakeFiles/obj.clangStaticAnalyzerCheckers.dir/WebKit/ForwardDeclChecker.cpp.o
[385/714] Building CXX object tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/InterpreterValuePrinter.cpp.o
[386/714] Building CXX object tools/clang/tools/clang-refactor/CMakeFiles/clang-refactor.dir/ClangRefactor.cpp.o
[387/714] Building CXX object tools/clang/tools/extra/clang-tidy/mpi/CMakeFiles/obj.clangTidyMPIModule.dir/MPITidyModule.cpp.o
[388/714] Building CXX object tools/clang/tools/extra/clang-apply-replacements/CMakeFiles/obj.clangApplyReplacements.dir/lib/Tooling/ApplyReplacements.cpp.o
[389/714] Linking CXX static library lib/libclangApplyReplacements.a
[390/714] Linking CXX executable bin/clang-apply-replacements
[391/714] Building CXX object tools/clang/lib/StaticAnalyzer/Checkers/CMakeFiles/obj.clangStaticAnalyzerCheckers.dir/WebKit/RetainPtrCtorAdoptChecker.cpp.o
[392/714] Building CXX object tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/ModularizeUtilities.cpp.o
FAILED: tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/ModularizeUtilities.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/clang-hip-vega20/botworker/clang-hip-vega20/llvm/tools/clang/tools/extra/modularize -I/home/botworker/bbot/clang-hip-vega20/llvm-project/clang-tools-extra/modularize -I/home/botworker/bbot/clang-hip-vega20/llvm-project/clang/include -I/home/botworker/bbot/clang-hip-vega20/botworker/clang-hip-vega20/llvm/tools/clang/include -I/home/botworker/bbot/clang-hip-vega20/botworker/clang-hip-vega20/llvm/include -I/home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/ModularizeUtilities.cpp.o -MF tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/ModularizeUtilities.cpp.o.d -o tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/ModularizeUtilities.cpp.o -c /home/botworker/bbot/clang-hip-vega20/llvm-project/clang-tools-extra/modularize/ModularizeUtilities.cpp
/home/botworker/bbot/clang-hip-vega20/llvm-project/clang-tools-extra/modularize/ModularizeUtilities.cpp: In member function ‘std::error_code Modularize::ModularizeUtilities::loadModuleMap(llvm::StringRef)’:
/home/botworker/bbot/clang-hip-vega20/llvm-project/clang-tools-extra/modularize/ModularizeUtilities.cpp:293:15: error: ‘class clang::ModuleMap’ has no member named ‘parseModuleMapFile’; did you mean ‘loadModuleMapFile’?
  293 |   if (ModMap->parseModuleMapFile(ModuleMapEntry, false, Dir)) {
      |               ^~~~~~~~~~~~~~~~~~
      |               loadModuleMapFile
[393/714] Linking CXX static library lib/libclangStaticAnalyzerCheckers.a
[394/714] Building CXX object tools/clang/tools/clang-installapi/CMakeFiles/clang-installapi.dir/ClangInstallAPI.cpp.o
[395/714] Building CXX object tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/CoverageChecker.cpp.o
[396/714] Linking CXX executable bin/clang-refactor
[397/714] Building CXX object tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ExpandModularHeadersPPCallbacks.cpp.o
[398/714] Building CXX object tools/clang/tools/clang-repl/CMakeFiles/clang-repl.dir/ClangRepl.cpp.o
[399/714] Building CXX object tools/clang/tools/clang-scan-deps/CMakeFiles/clang-scan-deps.dir/ClangScanDeps.cpp.o
[400/714] Building CXX object tools/clang/lib/Interpreter/CMakeFiles/obj.clangInterpreter.dir/Interpreter.cpp.o
[401/714] Linking CXX executable bin/clang-import-test
[402/714] Building CXX object tools/clang/tools/extra/clang-query/tool/CMakeFiles/clang-query.dir/ClangQuery.cpp.o
[403/714] Building CXX object tools/clang/tools/extra/clang-move/CMakeFiles/obj.clangMove.dir/HelperDeclRefGraph.cpp.o
[404/714] Building CXX object tools/clang/tools/extra/clang-reorder-fields/CMakeFiles/obj.clangReorderFields.dir/ReorderFieldsAction.cpp.o
[405/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/BadSignalToKillThreadCheck.cpp.o
[406/714] Building CXX object tools/clang/tools/extra/clang-tidy/altera/CMakeFiles/obj.clangTidyAlteraModule.dir/KernelNameRestrictionCheck.cpp.o
[407/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/LambdaFunctionNameCheck.cpp.o
[408/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/MacroParenthesesCheck.cpp.o
[409/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/MacroRepeatedSideEffectsCheck.cpp.o
[410/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/SuspiciousIncludeCheck.cpp.o
[411/714] Building CXX object tools/clang/tools/extra/clang-tidy/abseil/CMakeFiles/obj.clangTidyAbseilModule.dir/StringFindStartswithCheck.cpp.o
[412/714] Building CXX object tools/clang/tools/extra/clang-tidy/concurrency/CMakeFiles/obj.clangTidyConcurrencyModule.dir/ThreadCanceltypeAsynchronousCheck.cpp.o
[413/714] Building CXX object tools/clang/tools/extra/clang-tidy/cert/CMakeFiles/obj.clangTidyCERTModule.dir/SetLongJmpCheck.cpp.o
[414/714] Building CXX object tools/clang/tools/extra/modularize/CMakeFiles/modularize.dir/Modularize.cpp.o
[415/714] Building CXX object tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ClangTidy.cpp.o
[416/714] Building CXX object tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/InitVariablesCheck.cpp.o
[417/714] Building CXX object tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/MacroUsageCheck.cpp.o
[418/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/UnsafeFunctionsCheck.cpp.o
[419/714] Building CXX object tools/clang/tools/extra/clang-tidy/google/CMakeFiles/obj.clangTidyGoogleModule.dir/AvoidUnderscoreInGoogletestNameCheck.cpp.o
[420/714] Building CXX object tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProTypeVarargCheck.cpp.o
[421/714] Building CXX object tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/ProBoundsConstantArrayIndexCheck.cpp.o
[422/714] Building CXX object tools/clang/tools/extra/clang-tidy/google/CMakeFiles/obj.clangTidyGoogleModule.dir/TodoCommentCheck.cpp.o
[423/714] Building CXX object tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/NotNullTerminatedResultCheck.cpp.o
[424/714] Building CXX object tools/clang/tools/extra/clang-tidy/google/CMakeFiles/obj.clangTidyGoogleModule.dir/UpgradeGoogletestCaseCheck.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/132970