[clang] [clang-tools-extra] [clang][lex] Store non-owning options ref in `HeaderSearch` (PR #132780)

Tue Mar 25 12:29:09 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `clang-tools-extra,clang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/16262

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
759.984 [43/8/456] Linking CXX executable bin/llc
760.196 [42/8/457] Linking CXX executable bin/llvm-gpu-loader
760.664 [41/8/458] Linking CXX executable bin/c-index-test
761.019 [40/8/459] Linking CXX executable bin/llvm-extract
761.343 [39/8/460] Linking CXX executable bin/llvm-dwp
761.414 [38/8/461] Linking CXX executable bin/llvm-dwarfutil
761.456 [37/8/462] Linking CXX executable bin/llvm-libtool-darwin
761.518 [36/8/463] Linking CXX executable bin/llvm-exegesis
761.526 [35/8/464] Linking CXX executable bin/llvm-gsymutil
761.534 [34/8/465] Building CXX object tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o
FAILED: tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/source/Plugins/TypeSystem/Clang -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Plugins/TypeSystem/Clang -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/include -I/usr/include/python3.8 -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/../clang/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/../clang/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/source -isystem /usr/include/libxml2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-stringop-truncation -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o -MF tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o.d -o tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.dir/TypeSystemClang.cpp.o -c /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
In file included from /usr/include/c++/9/memory:80,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:16,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9:
/usr/include/c++/9/bits/unique_ptr.h: In instantiation of ‘typename std::_MakeUniq<_Tp>::__single_object std::make_unique(_Args&& ...) [with _Tp = clang::HeaderSearch; _Args = {std::shared_ptr<clang::HeaderSearchOptions>&, clang::SourceManager&, clang::DiagnosticsEngine&, clang::LangOptions&, clang::TargetInfo*}; typename std::_MakeUniq<_Tp>::__single_object = std::unique_ptr<clang::HeaderSearch>]’:
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1223:55:   required from here
/usr/include/c++/9/bits/unique_ptr.h:857:30: error: no matching function for call to ‘clang::HeaderSearch::HeaderSearch(std::shared_ptr<clang::HeaderSearchOptions>&, clang::SourceManager&, clang::DiagnosticsEngine&, clang::LangOptions&, clang::TargetInfo*)’
  857 |     { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:41:
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/../clang/include/clang/Lex/HeaderSearch.h:362:3: note: candidate: ‘clang::HeaderSearch::HeaderSearch(const clang::HeaderSearchOptions&, clang::SourceManager&, clang::DiagnosticsEngine&, const clang::LangOptions&, const clang::TargetInfo*)’
  362 |   HeaderSearch(const HeaderSearchOptions &HSOpts, SourceManager &SourceMgr,
      |   ^~~~~~~~~~~~
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/../clang/include/clang/Lex/HeaderSearch.h:362:43: note:   no known conversion for argument 1 from ‘std::shared_ptr<clang::HeaderSearchOptions>’ to ‘const clang::HeaderSearchOptions&’
  362 |   HeaderSearch(const HeaderSearchOptions &HSOpts, SourceManager &SourceMgr,
      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
761.790 [34/7/466] Linking CXX executable bin/llvm-isel-fuzzer
761.823 [34/6/467] Linking CXX executable bin/llvm-link
761.839 [34/5/468] Linking CXX executable bin/llvm-lipo
761.843 [34/4/469] Linking CXX executable bin/llvm-jitlink
761.908 [34/3/470] Linking CXX executable bin/llvm-nm
762.002 [34/2/471] Linking CXX executable bin/llvm-objdump
763.559 [34/1/472] Linking CXX executable bin/llvm-lto2
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/132780