[clang] [clang-tools-extra] [clang] improve class type sugar preservation in pointers to members (PR #130537)

Thu Mar 20 06:42:53 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `clang-tools-extra,clang` at step 10 "Add check check-libc-amdgcn-amd-amdhsa".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/1752

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 10 (Add check check-libc-amdgcn-amd-amdhsa) failure: test (failure)
...
[196/2772] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.nextupl.__internal__.dir/nextupl.cpp.o
[197/2772] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.fromfpl.__internal__.dir/fromfpl.cpp.o
[198/2772] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.nextdown.__internal__.dir/nextdown.cpp.o
[199/2772] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.nextupf.__internal__.dir/nextupf.cpp.o
[200/2772] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.fromfpf16.__internal__.dir/fromfpf16.cpp.o
[201/2772] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.nexttowardf16.__internal__.dir/nexttowardf16.cpp.o
[202/2772] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.nextdownf.__internal__.dir/nextdownf.cpp.o
[203/2772] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.nextupf16.__internal__.dir/nextupf16.cpp.o
[204/2772] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.fromfpxf.__internal__.dir/fromfpxf.cpp.o
[205/2772] Building CXX object libc/test/src/__support/CPP/CMakeFiles/libc.test.src.__support.CPP.type_traits_test.__hermetic__.__build__.dir/type_traits_test.cpp.o
FAILED: libc/test/src/__support/CPP/CMakeFiles/libc.test.src.__support.CPP.type_traits_test.__hermetic__.__build__.dir/type_traits_test.cpp.o 
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/./bin/clang++ --target=amdgcn-amd-amdhsa -DLIBC_NAMESPACE=__llvm_libc_21_0_0_git -D__LIBC_USE_FLOAT16_CONVERSION -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc -isystem /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/include/amdgcn-amd-amdhsa -O3 -DNDEBUG -UNDEBUG --target=amdgcn-amd-amdhsa -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ffixed-point -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wstrict-prototypes -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wthread-safety -Wno-multi-gpu -nogpulib -mcpu=native -flto -mcode-object-version=5 -MD -MT libc/test/src/__support/CPP/CMakeFiles/libc.test.src.__support.CPP.type_traits_test.__hermetic__.__build__.dir/type_traits_test.cpp.o -MF libc/test/src/__support/CPP/CMakeFiles/libc.test.src.__support.CPP.type_traits_test.__hermetic__.__build__.dir/type_traits_test.cpp.o.d -o libc/test/src/__support/CPP/CMakeFiles/libc.test.src.__support.CPP.type_traits_test.__hermetic__.__build__.dir/type_traits_test.cpp.o -c /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/test/src/__support/CPP/type_traits_test.cpp
clang++: /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/include/clang/AST/ASTContext.h:1704: clang::QualType clang::ASTContext::getTypeDeclType(const clang::TypeDecl*, const clang::TypeDecl*) const: Assertion `Decl && "Passed null for Decl param"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.	Program arguments: /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/./bin/clang++ --target=amdgcn-amd-amdhsa -DLIBC_NAMESPACE=__llvm_libc_21_0_0_git -D__LIBC_USE_FLOAT16_CONVERSION -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc -isystem /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/include/amdgcn-amd-amdhsa -O3 -DNDEBUG -UNDEBUG --target=amdgcn-amd-amdhsa -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ffixed-point -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wstrict-prototypes -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wthread-safety -Wno-multi-gpu -nogpulib -mcpu=native -flto -mcode-object-version=5 -MD -MT libc/test/src/__support/CPP/CMakeFiles/libc.test.src.__support.CPP.type_traits_test.__hermetic__.__build__.dir/type_traits_test.cpp.o -MF libc/test/src/__support/CPP/CMakeFiles/libc.test.src.__support.CPP.type_traits_test.__hermetic__.__build__.dir/type_traits_test.cpp.o.d -o libc/test/src/__support/CPP/CMakeFiles/libc.test.src.__support.CPP.type_traits_test.__hermetic__.__build__.dir/type_traits_test.cpp.o -c /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/test/src/__support/CPP/type_traits_test.cpp
1.	/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/test/src/__support/CPP/type_traits_test.cpp:337:3 <Spelling=/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/test/src/__support/CPP/type_traits_test.cpp:337:38>: current parser token ')'
2.	/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/test/src/__support/CPP/type_traits_test.cpp:15:1: parsing namespace '__llvm_libc_21_0_0_git'
3.	/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/test/src/__support/CPP/type_traits_test.cpp:16:1: parsing namespace '__llvm_libc_21_0_0_git::cpp'
4.	/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/test/src/__support/CPP/type_traits_test.cpp:326:40: parsing function body '__llvm_libc_21_0_0_git::cpp::LlvmLibcTypeTraitsTest_is_class::Run'
5.	/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/test/src/__support/CPP/type_traits_test.cpp:326:40: in compound statement ('{}')
6.	/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/__support/CPP/type_traits/is_class.h:27:32: instantiating variable definition '__llvm_libc_21_0_0_git::cpp::is_class_v<__llvm_libc_21_0_0_git::cpp::EnumClass>'
7.	/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/src/__support/CPP/type_traits/is_class.h:25:27: instantiating class definition '__llvm_libc_21_0_0_git::cpp::is_class<__llvm_libc_21_0_0_git::cpp::EnumClass>'
  #0 0x000070c4db5e49b0 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/libLLVMSupport.so.21.0git+0x1e49b0)
  #1 0x000070c4db5e1dbf llvm::sys::RunSignalHandlers() (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/libLLVMSupport.so.21.0git+0x1e1dbf)
  #2 0x000070c4db4df018 CrashRecoverySignalHandler(int) CrashRecoveryContext.cpp:0:0
  #3 0x000070c4dac42520 (/lib/x86_64-linux-gnu/libc.so.6+0x42520)
  #4 0x000070c4dac969fc __pthread_kill_implementation ./nptl/pthread_kill.c:44:76
  #5 0x000070c4dac969fc __pthread_kill_internal ./nptl/pthread_kill.c:78:10
  #6 0x000070c4dac969fc pthread_kill ./nptl/pthread_kill.c:89:10
  #7 0x000070c4dac42476 gsignal ./signal/../sysdeps/posix/raise.c:27:6
  #8 0x000070c4dac287f3 abort ./stdlib/abort.c:81:7
  #9 0x000070c4dac2871b _nl_load_domain ./intl/loadmsgcat.c:1177:9
 #10 0x000070c4dac39e96 (/lib/x86_64-linux-gnu/libc.so.6+0x39e96)
 #11 0x000070c4d81f9a06 clang::Sema::RequireCompleteTypeImpl(clang::SourceLocation, clang::QualType, clang::Sema::CompleteTypeKind, clang::Sema::TypeDiagnoser*) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0xdf9a06)
 #12 0x000070c4d81f9af9 clang::Sema::RequireCompleteType(clang::SourceLocation, clang::QualType, clang::Sema::CompleteTypeKind, clang::Sema::TypeDiagnoser&) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0xdf9af9)
 #13 0x000070c4d7aaf000 clang::Sema::GatherArgumentsForCall(clang::SourceLocation, clang::FunctionDecl*, clang::FunctionProtoType const*, unsigned int, llvm::ArrayRef<clang::Expr*>, llvm::SmallVectorImpl<clang::Expr*>&, clang::Sema::VariadicCallType, bool, bool) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0x6af000)
 #14 0x000070c4d7ab0344 clang::Sema::ConvertArgumentsForCall(clang::CallExpr*, clang::Expr*, clang::FunctionDecl*, clang::FunctionProtoType const*, llvm::ArrayRef<clang::Expr*>, clang::SourceLocation, bool) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0x6b0344)
 #15 0x000070c4d7ab1d97 clang::Sema::BuildResolvedCallExpr(clang::Expr*, clang::NamedDecl*, clang::SourceLocation, llvm::ArrayRef<clang::Expr*>, clang::SourceLocation, clang::Expr*, bool, clang::CallExpr::ADLCallKind) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0x6b1d97)
 #16 0x000070c4d7ea56f3 clang::Sema::BuildOverloadedCallExpr(clang::Scope*, clang::Expr*, clang::UnresolvedLookupExpr*, clang::SourceLocation, llvm::MutableArrayRef<clang::Expr*>, clang::SourceLocation, clang::Expr*, bool, bool) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0xaa56f3)
 #17 0x000070c4d7a661ba clang::Sema::BuildCallExpr(clang::Scope*, clang::Expr*, clang::SourceLocation, llvm::MutableArrayRef<clang::Expr*>, clang::SourceLocation, clang::Expr*, bool, bool) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0x6661ba)
 #18 0x000070c4d7a66e77 clang::Sema::ActOnCallExpr(clang::Scope*, clang::Expr*, clang::SourceLocation, llvm::MutableArrayRef<clang::Expr*>, clang::SourceLocation, clang::Expr*) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0x666e77)
 #19 0x000070c4d8134a65 clang::TreeTransform<(anonymous namespace)::TemplateInstantiator>::TransformCallExpr(clang::CallExpr*) SemaTemplateInstantiate.cpp:0:0
 #20 0x000070c4d8111056 clang::TreeTransform<(anonymous namespace)::TemplateInstantiator>::TransformType(clang::TypeLocBuilder&, clang::TypeLoc) SemaTemplateInstantiate.cpp:0:0
 #21 0x000070c4d811629a clang::TreeTransform<(anonymous namespace)::TemplateInstantiator>::TransformType(clang::TypeSourceInfo*) SemaTemplateInstantiate.cpp:0:0
 #22 0x000070c4d8119fca clang::Sema::SubstType(clang::TypeSourceInfo*, clang::MultiLevelTemplateArgumentList const&, clang::SourceLocation, clang::DeclarationName, bool) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0xd19fca)
 #23 0x000070c4d811a510 clang::Sema::SubstBaseSpecifiers(clang::CXXRecordDecl*, clang::CXXRecordDecl*, clang::MultiLevelTemplateArgumentList const&) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0xd1a510)
 #24 0x000070c4d811af82 clang::Sema::InstantiateClass(clang::SourceLocation, clang::CXXRecordDecl*, clang::CXXRecordDecl*, clang::MultiLevelTemplateArgumentList const&, clang::TemplateSpecializationKind, bool) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0xd1af82)
 #25 0x000070c4d816e405 clang::Sema::InstantiateClassTemplateSpecialization(clang::SourceLocation, clang::ClassTemplateSpecializationDecl*, clang::TemplateSpecializationKind, bool, bool) (/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/bin/../lib/../lib/libclangSema.so.21.0git+0xd6e405)

```

</details>

https://github.com/llvm/llvm-project/pull/130537